Return-path: Received: from wolverine02.qualcomm.com ([199.106.114.251]:41528 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755642Ab2FYTX6 (ORCPT ); Mon, 25 Jun 2012 15:23:58 -0400 Cc: "John W. Linville" , , Rodriguez Luis , , "Rajkumar Manoharan" , Sujith Manoharan , , , Senthil Balasubramanian , "Luis R. Rodriguez" From: Sujith Manoharan MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Message-ID: <20456.40631.937743.311973@gargle.gargle.HOWL> (sfid-20120625_212402_560499_2F9DF3CF) Date: Mon, 25 Jun 2012 22:54:07 +0530 To: Mohammed Shafi Shajakhan Subject: [PATCH v3 04/10] ath9k_hw: advertise WoW support for capable chipsets In-Reply-To: <1340633579-7514-5-git-send-email-mohammed@qca.qualcomm.com> References: <1340633579-7514-1-git-send-email-mohammed@qca.qualcomm.com> <1340633579-7514-5-git-send-email-mohammed@qca.qualcomm.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: Mohammed Shafi Shajakhan wrote: > From: Mohammed Shafi Shajakhan > > support WoW for all chipsets starting from AR9280, AR9285, AR9287, > AR9380, AR9382, AR9485, AR9462. Really all hardware may not support > WoW even though the flag is set and the WoW working depends on > your laptop, BIOS apart from the hardware. > > Cc: Senthil Balasubramanian > Cc: Rajkumar Manoharan > Cc: vadivel@qca.qualcomm.com > Signed-off-by: Luis R. Rodriguez > Signed-off-by: Mohammed Shafi Shajakhan > --- > drivers/net/wireless/ath/ath9k/hw.c | 8 ++++++++ > 1 files changed, 8 insertions(+), 0 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath9k/hw.c b/drivers/net/wireless/ath/ath9k/hw.c > index a42c26f..041d797 100644 > --- a/drivers/net/wireless/ath/ath9k/hw.c > +++ b/drivers/net/wireless/ath/ath9k/hw.c > @@ -2572,6 +2572,14 @@ int ath9k_hw_fill_cap_info(struct ath_hw *ah) > } > > > + if (AR_SREV_9280_20_OR_LATER(ah)) { > + pCap->hw_caps |= ATH9K_HW_WOW_DEVICE_CAPABLE | > + ATH9K_HW_WOW_PATTERN_MATCH_EXACT; > + > + if (AR_SREV_9280(ah)) > + pCap->hw_caps |= ATH9K_HW_WOW_PATTERN_MATCH_DWORD; > + } > + I don't think this is a good idea - please enable WoW only for cards that we have actually tested. Sujith