Return-path: Received: from wolverine02.qualcomm.com ([199.106.114.251]:61060 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755543Ab2FVMle (ORCPT ); Fri, 22 Jun 2012 08:41:34 -0400 Date: Fri, 22 Jun 2012 18:12:40 +0530 From: Rajkumar Manoharan To: Dan Carpenter CC: Kalle Valo , , Subject: Re: [PATCH 2/3] ath9k_hw: fix smatch warnings in spur_mitigate Message-ID: <20120622124238.GA10718@vmraj-lnx.users.atheros.com> (sfid-20120622_144138_572966_3DDD43C6) References: <1340303492-30947-1-git-send-email-rmanohar@qca.qualcomm.com> <1340303492-30947-3-git-send-email-rmanohar@qca.qualcomm.com> <87bokb4xof.fsf@purkki.adurom.net> <20120622092226.GA7934@vmraj-lnx.users.atheros.com> <877guz4lm9.fsf@purkki.adurom.net> <20120622115747.GE5390@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" In-Reply-To: <20120622115747.GE5390@mwanda> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Fri, Jun 22, 2012 at 02:57:47PM +0300, Dan Carpenter wrote: > On Fri, Jun 22, 2012 at 02:44:14PM +0300, Kalle Valo wrote: > > Rajkumar Manoharan writes: > > > > >> > - qCoff = qCoff & 0x7f; > > >> > + qCoff &= 0x7f; > > >> > > >> I'm curious, how does a change like this fix anything? To me it just > > >> looks same functionality, just a different operator is used. Am I > > >> missing something? > > > > > > Though it doesn't make a difference, somehow it fixes smatch warning. > > > I agree it is not the right fix. > > > > Ok, maybe it's just that smatch isn't clever enough with the &= operator. > > Dan? > > Ugh... I think it's debugging code that leaked into the wild. I > will remove that. > Thanks Dan. I'll rerun smatch once you pushed the changes. -Rajkumar