Return-path: Received: from wolverine01.qualcomm.com ([199.106.114.254]:58915 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753206Ab2FTFKs (ORCPT ); Wed, 20 Jun 2012 01:10:48 -0400 Cc: "John W. Linville" , , Rodriguez Luis , , Sujith Manoharan , , , , Senthil Balasubramanian , "Luis R. Rodriguez" Message-ID: <4FE15B4C.1000304@qca.qualcomm.com> (sfid-20120620_071053_968023_823D6C84) Date: Wed, 20 Jun 2012 10:40:36 +0530 From: Mohammed Shafi Shajakhan MIME-Version: 1.0 To: Rajkumar Manoharan Subject: Re: [PATCH 03/10] ath9k_hw: Add WoW hardware capability flags References: <1340120850-9155-1-git-send-email-mohammed@qca.qualcomm.com> <1340120850-9155-4-git-send-email-mohammed@qca.qualcomm.com> <20120619172047.GA7105@vmraj-lnx.qca.qualcomm.com> In-Reply-To: <20120619172047.GA7105@vmraj-lnx.qca.qualcomm.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tuesday 19 June 2012 10:50 PM, Rajkumar Manoharan wrote: > On Tue, Jun 19, 2012 at 09:17:23PM +0530, Mohammed Shafi Shajakhan wrote: >> From: Mohammed Shafi Shajakhan >> >> have seperate wow capability flags for >> *basic wow support >> *device capable of matching exact user defined pattern >> or de-authentication/disassoc pattern >> *device such AR9280 requires first four bytes for >> all sort of patterns >> >> Cc: Senthil Balasubramanian >> Cc: Rajkumar Manoharan >> Cc: vadivel@qca.qualcomm.com >> Tested-by: Mohammed Shafi Shajakhan >> Signed-off-by: Luis R. Rodriguez >> Signed-off-by: Mohammed Shafi Shajakhan >> --- >> drivers/net/wireless/ath/ath9k/hw.h | 20 ++++++++++++++++++++ >> 1 files changed, 20 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/net/wireless/ath/ath9k/hw.h b/drivers/net/wireless/ath/ath9k/hw.h >> index d0e14a3..73a1238 100644 >> --- a/drivers/net/wireless/ath/ath9k/hw.h >> +++ b/drivers/net/wireless/ath/ath9k/hw.h >> @@ -231,6 +231,23 @@ enum ath9k_hw_caps { >> ATH9K_HW_CAP_DFS = BIT(16), >> }; >> >> +/* >> + * enum ath9k_hw_wow_caps - WoW device capabilities >> + * @ATH9K_HW_WOW_DEVICE_CAPABLE: device revision is capable of WoW. >> + * @ATH9K_HW_WOW_PATTERN_MATCH_EXACT: device is capable of matching >> + * an exact user defined pattern or de-authentication/disassoc pattern. >> + * @ATH9K_HW_WOW_PATTERN_MATCH_DWORD: device requires the first four >> + * bytes of the pattern for user defined pattern, de-authentication and >> + * disassociation patterns for all types of possible frames recieved >> + * of those types. >> + */ >> + >> +enum ath9k_hw_wow_caps { >> + ATH9K_HW_WOW_DEVICE_CAPABLE = BIT(0), >> + ATH9K_HW_WOW_PATTERN_MATCH_EXACT = BIT(1), >> + ATH9K_HW_WOW_PATTERN_MATCH_DWORD = BIT(2), >> +}; >> + >> struct ath9k_hw_capabilities { >> u32 hw_caps; /* ATH9K_HW_CAP_* from ath9k_hw_caps */ >> u16 rts_aggr_limit; >> @@ -246,6 +263,9 @@ struct ath9k_hw_capabilities { >> u8 txs_len; >> u16 pcie_lcr_offset; >> bool pcie_lcr_extsync_en; >> +#ifdef CONFIG_PM_SLEEP >> + enum ath9k_hw_wow_caps wow_caps; >> +#endif > Why can't you align with existing HW_CAP_* flags? why do you need a separate > place holder? > i just thought as there are three flags specific, it would be nice to have it as a seperate enumeration. Just found a bug that if CONFIG_PM_SLEEP it would be a problem. will address this in v2. -- thanks, shafi