Return-path: Received: from mail-qa0-f46.google.com ([209.85.216.46]:52731 "EHLO mail-qa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932082Ab2FHNtq (ORCPT ); Fri, 8 Jun 2012 09:49:46 -0400 Received: by qadb17 with SMTP id b17so696658qad.19 for ; Fri, 08 Jun 2012 06:49:46 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1339137689.5832.2.camel@jlt3.sipsolutions.net> References: <1339014959.4523.0.camel@jlt3.sipsolutions.net> <1339053364.4517.0.camel@jlt3.sipsolutions.net> <20120607180325.7752b3c0@milhouse> <1339094215.4630.7.camel@jlt3.sipsolutions.net> <1339102567.4630.8.camel@jlt3.sipsolutions.net> <4FD11B47.10002@lwfinger.net> <1339136879.5832.1.camel@jlt3.sipsolutions.net> <1339137689.5832.2.camel@jlt3.sipsolutions.net> Date: Fri, 8 Jun 2012 15:49:45 +0200 Message-ID: (sfid-20120608_154952_254390_11D5B88A) Subject: Re: chip id 4318 regression: WARN_ON_ONCE(sdata->vif.hw_queue[i] >= n_queues)) From: Andre Heider To: Johannes Berg Cc: Larry Finger , =?ISO-8859-1?Q?Michael_B=FCsch?= , linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org, =?ISO-8859-2?Q?Rafa=B3_Mi=B3ecki?= Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Fri, Jun 8, 2012 at 8:41 AM, Johannes Berg wrote: > On Fri, 2012-06-08 at 08:27 +0200, Johannes Berg wrote: >> On Thu, 2012-06-07 at 23:47 +0200, Andre Heider wrote: >> > On Thu, Jun 7, 2012 at 11:21 PM, Larry Finger wrote: >> > > On 06/07/2012 03:56 PM, Johannes Berg wrote: >> > >> >> > >> On Thu, 2012-06-07 at 20:36 +0200, Johannes Berg wrote: >> > >> >> > >>> However, it's also possible to actually *use* the new mac80211 feature. >> > >>> That would also help with IEEE80211_TX_CTL_SEND_AFTER_DTIM, you could >> > >>> ask mac80211 to use a separate HW queue for it (for tx_ring_mcast.) This >> > >>> may be quicker. >> > >> >> > >> >> > >> This might do it, I haven't tested it at all: >> > >> >> > >> http://p.sipsolutions.net/3c6b003bb06e5298.txt >> > > >> > > >> > > With that patch, the driver never loads the firmware. I have not yet found >> > > the reason. >> > >> > Same here. >> >> It doesn't start any interfaces, right? >> >> The patch was incomplete -- it has to register all 5 queues not but >> might not use them, please try this: >> http://p.sipsolutions.net/69a78bbb83cd6421.txt > > No, this was wrong too, I forgot to correct the condition in > add_interface, this should be right: > > http://p.sipsolutions.net/854d460da251f9d6.txt Sorry, still not loading any firmware.