Return-path: Received: from charlotte.tuxdriver.com ([70.61.120.58]:35509 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754507Ab2FMSDH (ORCPT ); Wed, 13 Jun 2012 14:03:07 -0400 Date: Wed, 13 Jun 2012 13:50:31 -0400 From: "John W. Linville" To: Arend van Spriel Cc: =?iso-8859-1?Q?G=E1bor?= Stefanik , Linux Wireless List Subject: Re: [PATCH 5/5] brcmfmac: introduce checkdied debugfs functionality Message-ID: <20120613175030.GB6473@tuxdriver.com> (sfid-20120613_200311_515348_C49520E2) References: <1339275105-3593-1-git-send-email-arend@broadcom.com> <1339275105-3593-6-git-send-email-arend@broadcom.com> <4FD42939.2020404@broadcom.com> <20120611184330.GC30086@tuxdriver.com> <4FD89720.1020903@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 In-Reply-To: <4FD89720.1020903@broadcom.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, Jun 13, 2012 at 03:35:28PM +0200, Arend van Spriel wrote: > On 06/11/2012 08:43 PM, John W. Linville wrote: > > On Sun, Jun 10, 2012 at 06:57:29AM +0200, Arend van Spriel wrote: > >> On 06/10/2012 04:13 AM, G?bor Stefanik wrote: > >>> On Sat, Jun 9, 2012 at 10:51 PM, Arend van Spriel wrote: > >>>> The checkdied functionality provides useful information for analyzing > >>>> firmware crashes. By exposing this information to a debugfs file users > >>>> can easily provide its content in bug reports. The functionality is > >>>> available only when CONFIG_BRCMDBG is selected. > >>>> > >>>> Reviewed-by: Pieter-Paul Giesberts > >>>> Reviewed-by: Franky (Zhenhui) Lin > >>>> Signed-off-by: Arend van Spriel > >>>> --- > > >>>> + /* allocate buffer for console data */ > >>>> + if (console_size <= CONSOLE_BUFFER_MAX) > >>>> + conbuf = kzalloc(console_size+1, GFP_ATOMIC); > >>>> + > >>>> + if (!conbuf) > >>>> + return -ENOMEM; > >> > >> Probably would be better to use vmalloc() here or at least use > >> GFP_KERNEL here. > >> > >> John, any recommendations? > > > > vmalloc seems reasonable... > > > > Thanks, John > > Can you take the first four patches? I will make a v2 for this one. Let > me know if that is ok with you. Sure, fine. -- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready.