Return-path: Received: from wolverine01.qualcomm.com ([199.106.114.254]:4009 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751408Ab2FTFNx (ORCPT ); Wed, 20 Jun 2012 01:13:53 -0400 Message-ID: <4FE15BDE.10407@qca.qualcomm.com> (sfid-20120620_071355_815714_3CD354B0) Date: Wed, 20 Jun 2012 10:43:02 +0530 From: Mohammed Shafi Shajakhan MIME-Version: 1.0 To: Julian Calaby CC: "John W. Linville" , , , Rajkumar Manoharan , Sujith Manoharan , , , , Senthil Balasubramanian , "Luis R. Rodriguez" Subject: Re: [PATCH 05/10] ath9k: advertise supported WoW flags to upper layer References: <1340120850-9155-1-git-send-email-mohammed@qca.qualcomm.com> <1340120850-9155-6-git-send-email-mohammed@qca.qualcomm.com> In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: Hi Julian, > > On Wed, Jun 20, 2012 at 1:47 AM, Mohammed Shafi Shajakhan > wrote: >> From: Mohammed Shafi Shajakhan >> >> currently the code supports WoW triggers due to >> *magic packet >> *user defined patterns >> *deauth and disassoc patterns >> *disconnect - beacon miss, last beacon received timeout, >> no ack for keeep alive frames. >> >> we need to support other WoW offload features in the >> near future. also a minor cleanup. >> >> Cc: Senthil Balasubramanian >> Cc: Rajkumar Manoharan >> Cc: vadivel@qca.qualcomm.com >> Tested-by: Mohammed Shafi Shajakhan >> Signed-off-by: Luis R. Rodriguez >> Signed-off-by: Mohammed Shafi Shajakhan >> --- >> drivers/net/wireless/ath/ath9k/init.c | 20 ++++++++++++++++++-- >> 1 files changed, 18 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/net/wireless/ath/ath9k/init.c b/drivers/net/wireless/ath/ath9k/init.c >> index 9dfce1a..d08824f 100644 >> --- a/drivers/net/wireless/ath/ath9k/init.c >> +++ b/drivers/net/wireless/ath/ath9k/init.c >> @@ -688,8 +688,8 @@ void ath9k_set_hw_capab(struct ath_softc *sc, struct ieee80211_hw *hw) >> IEEE80211_HW_SPECTRUM_MGMT | >> IEEE80211_HW_REPORTS_TX_ACK_STATUS; >> >> - if (sc->sc_ah->caps.hw_caps& ATH9K_HW_CAP_HT) >> - hw->flags |= IEEE80211_HW_AMPDU_AGGREGATION; >> + if (ah->caps.hw_caps& ATH9K_HW_CAP_HT) >> + hw->flags |= IEEE80211_HW_AMPDU_AGGREGATION; > > This doesn't look like it belongs with the rest of the patch. > its a minor cleanup, but would be best to do it separately. there is also another place i did this thing, thanks i will address in v2. -- thanks, shafi