Return-path: Received: from he.sipsolutions.net ([78.46.109.217]:53132 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752277Ab2FTFcy (ORCPT ); Wed, 20 Jun 2012 01:32:54 -0400 Message-ID: <1340170374.4655.1.camel@jlt3.sipsolutions.net> (sfid-20120620_073257_581494_63A8D34C) Subject: Re: [PATCH 1/3] mac80211: Track auth frame registrations on IBSS ifaces From: Johannes Berg To: Will Hawkins Cc: linux-wireless@vger.kernel.org, linville@tuxdriver.com Date: Wed, 20 Jun 2012 07:32:54 +0200 In-Reply-To: <88045ffa83c9b4defb7b5eca98bc389ed6c2c5c1.1340142553.git.hawkinsw@opentechinstitute.org> References: <88045ffa83c9b4defb7b5eca98bc389ed6c2c5c1.1340142553.git.hawkinsw@opentechinstitute.org> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, 2012-06-19 at 17:59 -0400, Will Hawkins wrote: > Track userspace registrations for authentication > frames received on an IBSS interface. This field > will be used to decide whether or not to send > "open system" authentication frames when a new > station joins an adhoc network. > > Signed-off-by: Will Hawkins > --- > net/mac80211/cfg.c | 10 ++++++++++ > net/mac80211/ieee80211_i.h | 1 + > 2 files changed, 11 insertions(+) > > diff --git a/net/mac80211/cfg.c b/net/mac80211/cfg.c > index 498c94e..e00a696 100644 > --- a/net/mac80211/cfg.c > +++ b/net/mac80211/cfg.c > @@ -2486,6 +2486,16 @@ static void ieee80211_mgmt_frame_register(struct wiphy *wiphy, > u16 frame_type, bool reg) > { > struct ieee80211_local *local = wiphy_priv(wiphy); > + struct ieee80211_sub_if_data *sdata = IEEE80211_DEV_TO_SUB_IF(dev); > + > + if (sdata->vif.type == NL80211_IFTYPE_ADHOC && > + (frame_type == (IEEE80211_FTYPE_MGMT | IEEE80211_STYPE_AUTH))) { > + struct ieee80211_if_ibss *ifibss = &sdata->u.ibss; > + if (reg) > + ifibss->auth_frame_registrations++; > + else if (reg > 0) > + ifibss->auth_frame_registrations--; The "if (reg > 0)" here doesn't seem to make sense? johannes