Message-ID: <1340181856.4655.37.camel@jlt3.sipsolutions.net> (sfid-20120620_104434_561430_DB0A480E)
Subject: Re: [PATCH v2 3/7] nl80211/cfg80211: add ability to enable TX on
 op-channel
From: Johannes Berg <johannes@sipsolutions.net>
To: Victor Goldenshtein <victorg@ti.com>
Cc: linux-wireless@vger.kernel.org, kgiori@qca.qualcomm.com,
	mcgrof@frijolero.org, zefir.kurtisi@neratec.com,
	adrian.chadd@gmail.com, j@w1.fi, coelho@ti.com, assaf@ti.com,
	yoni.divinsky@ti.com, igalc@ti.com, adrian@freebsd.org,
	nbd@nbd.name, simon.wunderlich@s2003.tu-chemnitz.de
Date: Wed, 20 Jun 2012 10:44:16 +0200
In-Reply-To: <1340111463-4554-3-git-send-email-victorg@ti.com>
References: <1340111463-4554-1-git-send-email-victorg@ti.com>
	 <1340111463-4554-3-git-send-email-victorg@ti.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Sender: linux-wireless-owner@vger.kernel.org


> +	if ((!chan->radar_detect_timeout ||
> +	     time_is_after_jiffies(chan->radar_detect_timeout)) &&
> +	    (chan->flags & IEEE80211_CHAN_RADAR))
> +		return -EPERM;

Ok so you reject it if it's 0, but the jiffies calculation could return
0 too.. in fact, since jiffies start at -5 minutes on boot, you might
even hit it if you start radar detection 4 minutes after boot.

johannes