Return-path: Received: from wolverine01.qualcomm.com ([199.106.114.254]:35747 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932679Ab2GLPPD (ORCPT ); Thu, 12 Jul 2012 11:15:03 -0400 Message-ID: <4FFEE9ED.6020906@qca.qualcomm.com> (sfid-20120712_171508_194169_16F80243) Date: Thu, 12 Jul 2012 20:44:53 +0530 From: Mohammed Shafi Shajakhan MIME-Version: 1.0 To: Johannes Berg CC: Subject: Re: [RFC] nl80211: Avoid checking for empty WoWLAN triggers References: <1341914875-14647-1-git-send-email-mohammed@qca.qualcomm.com> <1341918365.4475.9.camel@jlt3.sipsolutions.net> <4FFC0F22.6040906@qca.qualcomm.com> <1341919201.4475.11.camel@jlt3.sipsolutions.net> <4FFD1014.2000109@qca.qualcomm.com> <1342103072.4531.26.camel@jlt3.sipsolutions.net> In-Reply-To: <1342103072.4531.26.camel@jlt3.sipsolutions.net> Content-Type: text/plain; charset="UTF-8"; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: Hi Johannes, thanks for getting back to this :) On Thursday 12 July 2012 07:54 PM, Johannes Berg wrote: > On Wed, 2012-07-11 at 11:03 +0530, Mohammed Shafi Shajakhan wrote: > >>> I don't know if there's any advantage. It could be useful for example to >>> get a connection up quicker after resume. I just didn't want to preclude >>> that use case. >>> >> >> sorry i just missed this thing. rdev->wowlan is made 'false' for empty > > I think you mean "NULL"? oh yes. > > Maybe something like this would make sense then? > > http://p.sipsolutions.net/2aac79bcfe3a9b8b.txt yeah this was the thing i am proposing http://www.spinics.net/lists/linux-wireless/msg94023.html your patch is better optimized as it avoids a bool variable to check for wow disable command, so this should be fine with the other iw patch to check for empty triggers ? http://www.spinics.net/lists/linux-wireless/msg94022.html thank you! > > johannes > -- thanks, shafi