Message-ID: <1341250736.19642.22.camel@jlt3.sipsolutions.net> (sfid-20120702_193900_762372_464D5AD4)
Subject: Re: Kernel oops in __netif_schedule() for at76c50x-usb
From: Johannes Berg <johannes@sipsolutions.net>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: wireless <linux-wireless@vger.kernel.org>
Date: Mon, 02 Jul 2012 19:38:56 +0200
In-Reply-To: <4FF1C887.8090009@lwfinger.net> (sfid-20120702_181310_720968_3FE88ADC)
References: <4FF1BC71.4070002@lwfinger.net>
	  (sfid-20120702_172127_238924_ED185EFD) <1341243087.19642.20.camel@jlt3.sipsolutions.net>
	 <4FF1C887.8090009@lwfinger.net> (sfid-20120702_181310_720968_3FE88ADC)
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Sender: linux-wireless-owner@vger.kernel.org


> > I'm not sure which fix is correct though. Should we have software QoS
> > queues for these drivers, but we'll never use them? Then this would
> > work:
> > http://p.sipsolutions.net/e015bf7db9a05887.txt
> >
> > Or we could change the enable code path. Hmm.
> 
> That patch does prevent the oops. I was not able to make a connection with the 
> device, but I just acquired it, and I'm not sure of its quality, or that of the 
> driver.

I don't think that device works today -- IIRC it requires the BSSID
before authentication and that wasn't possible before the auth redesign.

> It does scan OK, and I think the patch is OK. I'll do more tests with 
> b43legacy later as the machine with that iface is busy. I will also test b43 on 
> the PPC using the open-source firmware.
> 
> Although you may want to change the enable code path, some patch will be needed 
> to prevent a regression in 3.5. If this is the one, you may add a "Tested-by" 
> for me.

Thanks. Could you try this patch instead? I think it makes more sense.

http://p.sipsolutions.net/c3e9b814a409ca11.txt

johannes