Return-path: Received: from he.sipsolutions.net ([78.46.109.217]:38746 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752741Ab2GCQrt (ORCPT ); Tue, 3 Jul 2012 12:47:49 -0400 Message-ID: <1341334067.20124.9.camel@jlt3.sipsolutions.net> (sfid-20120703_184752_028988_8C6C0D64) Subject: Re: [PATCH] compat-wireless: fix debugging in iwlwifi From: Johannes Berg To: Joe Perches Cc: "Luis R. Rodriguez" , linux-wireless Date: Tue, 03 Jul 2012 18:47:47 +0200 In-Reply-To: <1341332934.2164.17.camel@joe2Laptop> References: <1341322108.20124.3.camel@jlt3.sipsolutions.net> (sfid-20120703_181714_567213_CDA8319F) <1341332487.20124.7.camel@jlt3.sipsolutions.net> <1341332934.2164.17.camel@joe2Laptop> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, 2012-07-03 at 09:28 -0700, Joe Perches wrote: > On Tue, 2012-07-03 at 18:21 +0200, Johannes Berg wrote: > > On Tue, 2012-07-03 at 09:16 -0700, Luis R. Rodriguez wrote: > > > On Tue, Jul 3, 2012 at 8:47 AM, Luis R. Rodriguez wrote: > > > > On Tue, Jul 3, 2012 at 6:28 AM, Johannes Berg wrote: > > > >> From: Johannes Berg > > > >> > > > >> As compat includes linux/device.h well before iwlwifi, the > > > >> definitions from there are used without DEBUG, but iwlwifi > > > >> defines DEBUG to get debug output. Use dev_printk instead > > > >> of dev_dbg to get debugging back. > > > >> > > > >> Signed-off-by: Johannes Berg > > > > > > > > Applied and pushed, thanks! > > > > > > On today's linux-next.git the dev_dbg() changed to dev_err(), I've > > > updated the patch to reflect this. > > > > Huh, sorry. Please drop this for now -- the patch to change it *from* > > dev_err *to* dev_dbg is only in my iwlwifi-next tree now. > > And besides, the concept is wrong. > > There's no reason to drop dynamic_debug support by > forcing output to KERN_DEBUG. Well, the thing is, "#define DEBUG" doesn't work in compat-wireless ... We add it to the Makefile though I guess johannes