Return-path: Received: from mx1.redhat.com ([209.132.183.28]:47786 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751798Ab2G3Hej (ORCPT ); Mon, 30 Jul 2012 03:34:39 -0400 Date: Mon, 30 Jul 2012 09:33:28 +0200 From: Stanislaw Gruszka To: Matt Chen Cc: users@rt2x00.serialmonkey.com, linux-wireless@vger.kernel.org, kevin.chou@mediatek.com, woody.hung@mediatek.com Subject: Re: [rt2x00-users] [PATCH] rt2x00 : fix rt3290 resuming failed. Message-ID: <20120730073327.GB2395@redhat.com> (sfid-20120730_093443_672272_8700E570) References: <1343372634-19870-1-git-send-email-machen@suse.com> <20120727101840.GA2436@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 In-Reply-To: Sender: linux-wireless-owner@vger.kernel.org List-ID: Hi On Fri, Jul 27, 2012 at 10:22:44PM +0800, Matt Chen wrote: > 2012/7/27 Stanislaw Gruszka : > > On Fri, Jul 27, 2012 at 03:03:54PM +0800, Chen, Chien-Chia wrote: > >> This patch is going to fix the resuming failed from S3/S4 > >> for rt3290 chip. > >> > >> Signed-off-by: Chen, Chien-Chia > >> CC-by: Kevin Chou > > > > Could you please post patches that compile? Also you did not set true > Compile ? you mean the *.o files and *.ko ? Patch does not compile: drivers/net/wireless/rt2x00/rt2800lib.c:5163: error: static declaration of ‘rt2800_enable_wlan_rt3290’ follows non-static declaration drivers/net/wireless/rt2x00/rt2800lib.h:212: note: previous declaration of ‘rt2800_enable_wlan_rt3290’ was here make[1]: *** [drivers/net/wireless/rt2x00/rt2800lib.o] Error 1 make: *** [drivers/net/wireless/rt2x00/] Error 2 How did you tested the patch ? > > author of the patch. Additionally, since repost that patch with changes, > > you should mark version of the patch and provide information about > > changes, like for example here: > Hmm....I added the Author: Woody Hung but > don't know why it doesn't show here. :( So fix that. Post patch to yourself first to see if setting works. Stanislaw