Return-path: Received: from mail-pb0-f46.google.com ([209.85.160.46]:64548 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752181Ab2GCQRM (ORCPT ); Tue, 3 Jul 2012 12:17:12 -0400 Received: by pbbrp8 with SMTP id rp8so9454077pbb.19 for ; Tue, 03 Jul 2012 09:17:12 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1341322108.20124.3.camel@jlt3.sipsolutions.net> From: "Luis R. Rodriguez" Date: Tue, 3 Jul 2012 09:16:51 -0700 Message-ID: (sfid-20120703_181726_112102_FA54256F) Subject: Re: [PATCH] compat-wireless: fix debugging in iwlwifi To: Johannes Berg Cc: linux-wireless Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, Jul 3, 2012 at 8:47 AM, Luis R. Rodriguez wrote: > On Tue, Jul 3, 2012 at 6:28 AM, Johannes Berg wrote: >> From: Johannes Berg >> >> As compat includes linux/device.h well before iwlwifi, the >> definitions from there are used without DEBUG, but iwlwifi >> defines DEBUG to get debug output. Use dev_printk instead >> of dev_dbg to get debugging back. >> >> Signed-off-by: Johannes Berg > > Applied and pushed, thanks! On today's linux-next.git the dev_dbg() changed to dev_err(), I've updated the patch to reflect this. mcgrof@tux ~/devel/compat-wireless (git::master)$ git diff diff --git a/patches/57-iwlwifi-debug-fix.patch b/patches/57-iwlwifi-debug-fix.patch index 4b2dfa9..1bfc88f 100644 --- a/patches/57-iwlwifi-debug-fix.patch +++ b/patches/57-iwlwifi-debug-fix.patch @@ -9,7 +9,7 @@ dev_printk to make them show up again. va_copy(args2, args); vaf.va = &args2; -- dev_dbg(dev, "%c %s %pV", in_interrupt() ? 'I' : 'U', +- dev_err(dev, "%c %s %pV", in_interrupt() ? 'I' : 'U', - function, &vaf); + dev_printk(KERN_DEBUG, dev, "%c %s %pV", + in_interrupt() ? 'I' : 'U' Luis