Return-path: Received: from wolverine01.qualcomm.com ([199.106.114.254]:19265 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752105Ab2HTHFj (ORCPT ); Mon, 20 Aug 2012 03:05:39 -0400 Message-ID: <5031E1B0.3000302@qca.qualcomm.com> (sfid-20120820_090542_237368_2438DEC6) Date: Mon, 20 Aug 2012 10:05:20 +0300 From: Kalle Valo MIME-Version: 1.0 To: Thomas Pedersen CC: , Subject: Re: [PATCH] ath6kl: rework scheduled scan References: <1345074684-4662-1-git-send-email-c_tpeder@qca.qualcomm.com> In-Reply-To: <1345074684-4662-1-git-send-email-c_tpeder@qca.qualcomm.com> Content-Type: text/plain; charset="ISO-8859-1" Sender: linux-wireless-owner@vger.kernel.org List-ID: On 08/16/2012 02:51 AM, Thomas Pedersen wrote: > This patch reflects changes in the firmware scheduled scan > implementation to behave better in cases with multiple concurrent vifs. > Major changes: > > - scheduled scan filters and state are now programmed per-vif. > - decouple scheduled scan from host sleep. > > To maintain graceful failure with old firmwares, a new firmware > capability bit is introduced: ATH6KL_FW_CAPABILITY_SCHED_SCAN_V2. > ath6kl simply won't advertise scheduled scan to cfg80211 if the > SCHED_SCAN_V2 is not supported. > > Since firmwares from here on out won't support the previous implicit API > for scheduled scan (set WoW filters and host sleep), bump the firmware > API to protect old drivers. > > Unfortunately, due to firmware RAM constraints ath6kl still cannot > expect a scan complete event at the end of a scheduled scan results > cycle, so the sched_scan_timer is retained. > > Signed-off-by: Thomas Pedersen Thanks, applied. Kalle