Return-path: Received: from wolverine01.qualcomm.com ([199.106.114.254]:62550 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754373Ab2HPGV3 (ORCPT ); Thu, 16 Aug 2012 02:21:29 -0400 Message-ID: <502C9160.3000401@qca.qualcomm.com> (sfid-20120816_082133_290972_13251599) Date: Thu, 16 Aug 2012 11:51:20 +0530 From: Vasanthakumar Thiagarajan MIME-Version: 1.0 To: Kalle Valo CC: , Subject: Re: [PATCH V2 1/2] ath6kl: Fix potential skb double free in ath6kl_wmi_sync_point() References: <1344919234-5012-1-git-send-email-vthiagar@qca.qualcomm.com> <502A60BB.7000106@qca.qualcomm.com> In-Reply-To: <502A60BB.7000106@qca.qualcomm.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tuesday 14 August 2012 07:59 PM, Kalle Valo wrote: > On 08/14/2012 07:40 AM, Vasanthakumar Thiagarajan wrote: >> skb given to ath6kl_control_tx() is owned by ath6kl_control_tx(). >> Calling function should not free the skb for error cases. >> This is found during code review. >> >> Signed-off-by: Vasanthakumar Thiagarajan > > Thanks, both applied. There was a checkpatch warning about parenthesis > alignment in the first patch but I fixed it. Thanks, but for some reason i dont see any checkpatch warnings. Vasanth