Return-path: Received: from mms1.broadcom.com ([216.31.210.17]:2890 "EHLO mms1.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751264Ab2HAQk3 (ORCPT ); Wed, 1 Aug 2012 12:40:29 -0400 Message-ID: <50195BEF.8010206@broadcom.com> (sfid-20120801_184037_935174_C86A56D1) Date: Wed, 1 Aug 2012 18:40:15 +0200 From: "Arend van Spriel" MIME-Version: 1.0 To: "John W. Linville" cc: "Josh Boyer" , "Johannes Berg" , "Brett Rudley" , "Roland Vossen" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, "Seth Forshee" Subject: Re: assert_cfg80211_lock warning with Linux v3.5-8833-g2d53492 References: <20120801131232.GA1785@zod.bos.redhat.com> <20120801141810.GB27433@tuxdriver.com> <50194D7A.6060400@broadcom.com> <5019506C.6020707@broadcom.com> <20120801155252.GE27433@tuxdriver.com> In-Reply-To: <20120801155252.GE27433@tuxdriver.com> Content-Type: text/plain; charset=iso-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 08/01/2012 05:52 PM, John W. Linville wrote: > On Wed, Aug 01, 2012 at 05:51:08PM +0200, Arend van Spriel wrote: >> On 08/01/2012 05:38 PM, Arend van Spriel wrote: >>>> brcmsmac needs to hold cfg80211_mutex before calling freq_reg_info... >>>>> >>>>> It looks like those calls were added in mid-June. >>>>> >>> I think mid-june sounds about right. We never observed the warning when >>> changes to use regulatory infrastructure were tested/reviewed. Should >>> this precondition be mentioned in cfg80211.h? >>> >>> Gr. AvS >> >> Diving in further it seems brcmsmac can not grab the cfg80211_mutex. So >> another solution is needed. > > Do we need to revert those patches? > either that or fix it. Gr. AvS