Return-path: Received: from charlotte.tuxdriver.com ([70.61.120.58]:42916 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756099Ab2HAQAU (ORCPT ); Wed, 1 Aug 2012 12:00:20 -0400 Date: Wed, 1 Aug 2012 11:52:53 -0400 From: "John W. Linville" To: Arend van Spriel Cc: Josh Boyer , Johannes Berg , Brett Rudley , Roland Vossen , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Seth Forshee Subject: Re: assert_cfg80211_lock warning with Linux v3.5-8833-g2d53492 Message-ID: <20120801155252.GE27433@tuxdriver.com> (sfid-20120801_180109_487466_57357472) References: <20120801131232.GA1785@zod.bos.redhat.com> <20120801141810.GB27433@tuxdriver.com> <50194D7A.6060400@broadcom.com> <5019506C.6020707@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <5019506C.6020707@broadcom.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, Aug 01, 2012 at 05:51:08PM +0200, Arend van Spriel wrote: > On 08/01/2012 05:38 PM, Arend van Spriel wrote: > >> brcmsmac needs to hold cfg80211_mutex before calling freq_reg_info... > >> > > >> > It looks like those calls were added in mid-June. > >> > > > I think mid-june sounds about right. We never observed the warning when > > changes to use regulatory infrastructure were tested/reviewed. Should > > this precondition be mentioned in cfg80211.h? > > > > Gr. AvS > > Diving in further it seems brcmsmac can not grab the cfg80211_mutex. So > another solution is needed. Do we need to revert those patches? -- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready.