Return-path: Received: from mx1.redhat.com ([209.132.183.28]:44860 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751738Ab2HMHhA (ORCPT ); Mon, 13 Aug 2012 03:37:00 -0400 Date: Mon, 13 Aug 2012 09:36:38 +0200 From: Stanislaw Gruszka To: "Goldenshtein, Victor" Cc: linux-wireless@vger.kernel.org, kgiori@qca.qualcomm.com, mcgrof@frijolero.org, zefir.kurtisi@neratec.com, adrian.chadd@gmail.com, j@w1.fi, johannes@sipsolutions.net, coelho@ti.com, assaf@ti.com, yoni.divinsky@ti.com, igalc@ti.com, adrian@freebsd.org, nbd@nbd.name, simon.wunderlich@s2003.tu-chemnitz.de Subject: Re: [PATCH v3 2/7] mac80211: add radar detection command/event Message-ID: <20120813073637.GB2272@redhat.com> (sfid-20120813_093704_725201_90D97E6C) References: <1344426823-1795-1-git-send-email-victorg@ti.com> <1344426823-1795-3-git-send-email-victorg@ti.com> <20120810162810.GB17559@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: Sender: linux-wireless-owner@vger.kernel.org List-ID: On Sun, Aug 12, 2012 at 10:31:40AM +0300, Goldenshtein, Victor wrote: > On Fri, Aug 10, 2012 at 7:28 PM, Stanislaw Gruszka wrote: > > On Wed, Aug 08, 2012 at 02:53:38PM +0300, Victor Goldenshtein wrote: > >> --- a/include/net/mac80211.h > >> +++ b/include/net/mac80211.h > >> @@ -2262,6 +2262,10 @@ enum ieee80211_rate_control_changed { > >> * The callback will be called before each transmission and upon return > >> * mac80211 will transmit the frame right away. > >> * The callback is optional and can (should!) sleep. > >> + * > >> +* @start_radar_detection: Start radar detection on current operational > >> + * channel, once started it will continuously monitor for radars as long > >> + * as the channel active. > >> */ > >> struct ieee80211_ops { > >> void (*tx)(struct ieee80211_hw *hw, struct sk_buff *skb); > >> @@ -2404,6 +2408,10 @@ struct ieee80211_ops { > >> > >> void (*mgd_prepare_tx)(struct ieee80211_hw *hw, > >> struct ieee80211_vif *vif); > >> + > >> + int (*start_radar_detection)(struct ieee80211_hw *hw, > >> + struct ieee80211_vif *vif, > >> + struct ieee80211_channel *chan); > > > > Why we need new callback? I.e. why this can be done by ->config ? > > > > See proposed RFC and previous threads. I can not find mail where this is explained, could you please provide link. Stanislaw