Return-path: Received: from mga02.intel.com ([134.134.136.20]:47256 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757421Ab2HWSP0 (ORCPT ); Thu, 23 Aug 2012 14:15:26 -0400 Date: Thu, 23 Aug 2012 20:26:30 +0200 From: Samuel Ortiz To: Tejun Heo Cc: Lauro Ramos Venancio , Aloisio Almeida Jr , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] nfc: use system_nrt_wq instead of custom ones Message-ID: <20120823182630.GA4771@sortiz-mobl> (sfid-20120823_201543_041205_4A8BE719) References: <20120822232216.GP19212@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20120822232216.GP19212@google.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: Hi Tejun, On Wed, Aug 22, 2012 at 04:22:16PM -0700, Tejun Heo wrote: > NFC is using a number of custom ordered workqueues w/ WQ_MEM_RECLAIM. > WQ_MEM_RECLAIM is unnecessary unless NFC is gonna be used as transport > for storage device, and all use cases match one work item to one > ordered workqueue - IOW, there's no actual ordering going on at all > and using system_nrt_wq gives the same behavior. > > There's nothing to be gained by using custom workqueues. Use > system_nrt_wq instead and drop all the custom ones. > > Only compile tested. Tested here, and it works fine. I'm queueing this one up to my nfc-next branch, thanks a lot for the follow up. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/