Return-path: Received: from he.sipsolutions.net ([78.46.109.217]:44569 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752352Ab2HATdS (ORCPT ); Wed, 1 Aug 2012 15:33:18 -0400 Message-ID: <1343849597.4638.20.camel@jlt3.sipsolutions.net> (sfid-20120801_213322_205317_A7634767) Subject: Re: [RFC 7/8] mac80211: support extended channel switch From: Johannes Berg To: Arik Nemtsov Cc: linux-wireless@vger.kernel.org Date: Wed, 01 Aug 2012 21:33:17 +0200 In-Reply-To: (sfid-20120801_212830_973950_C3E35CD5) References: <1343834487-23737-1-git-send-email-johannes@sipsolutions.net> <1343834487-23737-8-git-send-email-johannes@sipsolutions.net> (sfid-20120801_212830_973950_C3E35CD5) Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, 2012-08-01 at 22:28 +0300, Arik Nemtsov wrote: > > +static void > > +ieee80211_sta_process_chanswitch(struct ieee80211_sub_if_data *sdata, > > + u8 new_chan_no, u8 count, u8 mode, > > + enum ieee80211_band new_band, > > + struct ieee80211_bss *bss, u64 timestamp) > > { > > struct cfg80211_bss *cbss = > > container_of((void *)bss, struct cfg80211_bss, priv); > > struct ieee80211_channel *new_ch; > > struct ieee80211_if_managed *ifmgd = &sdata->u.mgd; > > - int new_freq = ieee80211_channel_to_frequency(sw_elem->new_ch_num, > > - cbss->channel->band); > > + int new_freq = ieee80211_channel_to_frequency(new_chan_no, new_band); > > I'm not sure a channel switch between bands should be allowed. Case in > point - a device might have different HT capabilities between bands, > so different rates might need to be programmed to FW. This would > require a re-assoc.. Hmm, that might require some new flags or something? I'm not even sure the extended chanswitch is allowed to switch bands, but by the look of it that must have been the intent? johannes