Return-path: Received: from mail.active-venture.com ([67.228.131.205]:54698 "EHLO mail.active-venture.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753523Ab2HGLHk (ORCPT ); Tue, 7 Aug 2012 07:07:40 -0400 Date: Tue, 7 Aug 2012 04:07:48 -0700 From: Guenter Roeck To: Randy Dunlap Cc: Christopher Sacchi , linux-wireless@vger.kernel.org, Linux Kernel Mailing List Subject: Re: [PATCH]: Autosleep patch. Message-ID: <20120807110748.GA12534@roeck-us.net> (sfid-20120807_130803_154390_92139B9A) References: <501FE4E9.3080004@xenotime.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <501FE4E9.3080004@xenotime.net> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, Aug 06, 2012 at 08:38:17AM -0700, Randy Dunlap wrote: > On 08/06/2012 08:13 AM, Christopher Sacchi wrote: > > > This patch (listed below), changes an old function in autosleep.c in > > kernel version 3.5. It's code is listed from the first -- line to the > > 2nd to last -- line. > > This patch was checked with checkpatch.pl with no errors: > > -- > > --- power/autosleep.c 2012-07-21 20:58:29.000000000 +0000 > > +++ power/autosleepnew.c 2012-08-06 10:52:26.000000000 +0000 > > > The file names should include the full path from the top level of the > kernel source tree. E.g.: > > --- linux.orig/kernel/power/autosleep.c > +++ linux/kernel/power/autosleep.c > > This patch uses the name autosleepnew.c, which is not what is > required/expected. > > Your previous patches were for wireless (mac80211) components, so they > needed to go to the linux-wireless mailing list. This patch is not > about wireless, so don't send it to that mailing list, although you > could send it to the linux-pm@vger.kernel.org mailing list. > Please see the MAINTAINERS file for where to send patches. > > > > @@ -30,7 +30,7 @@ static void try_to_suspend(struct work_s > > if (!pm_get_wakeup_count(&initial_count, true)) > > goto out; > > > > - mutex_lock(&autosleep_lock); > > + mutex_lock_interruptable(); > > Plus, this code obviously never compiled. Nor does the submitter ever explain what he actually tries to accomplish. Guenter > > if (!pm_save_wakeup_count(initial_count)) { > > mutex_unlock(&autosleep_lock); > > Signed-off-by: Christopher P. Sacchi > > -- > > Signed-off-by: line is not part of the patch. It should be near the > end of the patch description, before the actual patch. > > Again, please read and follow Documentation/SubmittingPatches. > > thanks. > > -- > ~Randy >