Return-path: Received: from nbd.name ([46.4.11.11]:37638 "EHLO nbd.name" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753447Ab2HIV2j (ORCPT ); Thu, 9 Aug 2012 17:28:39 -0400 Message-ID: <50242B80.4060509@openwrt.org> (sfid-20120809_232842_695507_CBB60F33) Date: Thu, 09 Aug 2012 23:28:32 +0200 From: Felix Fietkau MIME-Version: 1.0 To: "Luis R. Rodriguez" CC: Pavel Roskin , Lorenzo Bianconi , linux-wireless@vger.kernel.org Subject: Re: [PATCH v2] ath9k: decrypt_error flag issue References: <20120809173435.GQ3745@lenteja.do-not-panic.com> <20120809170757.748b68bf@mj> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 2012-08-09 11:21 PM, Luis R. Rodriguez wrote: > On Thu, Aug 9, 2012 at 2:07 PM, Pavel Roskin wrote: >> On Thu, 9 Aug 2012 11:10:38 -0700 >> "Luis R. Rodriguez" wrote: >> >>> And this would lead to .. what? How did you realize this? Can you >>> please resend and add all this information to the commit log message? >> >> Also please use a better subject. For example: >> >> ath9k: fix decrypt_error initialization in ath_rx_tasklet() >> >> "issue" is too vague. > > Also -- what I was getting at is to evaluate whether or not this is an > important fix or critical. To determine if its critical it helps to > understand exactly what negative behavior was observed. If its > critical it can go to stable but I have a feeling this is not > critical. If its not critical and only important although it won't go > to stable I'll still cherry pick it for the stable compat-wireless > releases. I think it's critical enough for stable. I think when using CCMP encryption, high CPU load can get the connection stuck (because of CCMP PN corruption when the issue occurs). - Felix