MIME-Version: 1.0
In-Reply-To: <1343924881-31418-1-git-send-email-hauke@hauke-m.de>
References: <1343924881-31418-1-git-send-email-hauke@hauke-m.de>
From: "Luis R. Rodriguez" <mcgrof@gmail.com>
Date: Mon, 6 Aug 2012 11:33:47 -0700
Message-ID: <CAB=NE6Wj3tFVUWNTE1dDk2VopeqPvc4g57hwaETQQR4vA=tcJA@mail.gmail.com> (sfid-20120806_203414_050160_92F6072A)
Subject: Re: [PATCH 1/2] compat: remove backport of irq_modify_status
To: Hauke Mehrtens <hauke@hauke-m.de>
Cc: linux-wireless@vger.kernel.org, Luciano Coelho <coelho@ti.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-wireless-owner@vger.kernel.org

On Thu, Aug 2, 2012 at 9:28 AM, Hauke Mehrtens <hauke@hauke-m.de> wrote:
> Only kernel >= 2.6.39 irq_to_desc or irq_desc are exporting, so that
> compat is not able to access this on the kernel versions where it is
> needed. irq_to_desc and irq_desc are defined in the header files so
> compilation works, but the module is not loadable because of the
> missing exported symbol which make compat unusable on all these kernel
> versions. Remove this function, no driver seams to need it.
>
> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>

Thanks, if you look at my patch 3e3c23e042 on compat.git it says that
I added this stuff due to the patch that is now merged on linux.git
ee9c8a04 -- wl1251: fix oops on early interrupt. That patch was a
stable fix merged down to v3.4.6. The implications of your tests are
that wl1251 must be disabled on older kernel or another equivalent
stable fix must be backported for that driver into
compat-wireless.git.

I frankly have too much patch catching up to so I cannot take care of
this right now so what I will do is disable wl1251 on the updated
stable releases for kernels older than v2.6.38 which require all this
backport work. I welcome patches to properly backpor this though.

I should point out too that this patch was a linux-next.git patch that
got marked as stable and once merged onto v3.4.6 it required a *new*
backport change that was not required on a release based on v3.4.5.
This means that *any* stable fix on older kernels could potentially
regress stable compat releases. The only way to not regress stable
compat releases then is if there is no delta from the pulled upstream
code as there is no gaurantee a stable fix did not implement usage of
a feature implemented or available only on certain newer kernels.

Luca, for what kernels do you guys really need wl1251 enabled for?

  Luis