Return-path: Received: from mail-wi0-f178.google.com ([209.85.212.178]:36456 "EHLO mail-wi0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757952Ab2HJJcz convert rfc822-to-8bit (ORCPT ); Fri, 10 Aug 2012 05:32:55 -0400 Received: by wibhr14 with SMTP id hr14so1191014wib.1 for ; Fri, 10 Aug 2012 02:32:54 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1344544690-11280-1-git-send-email-zajec5@gmail.com> <5024CE29.5030500@broadcom.com> Date: Fri, 10 Aug 2012 11:32:54 +0200 Message-ID: (sfid-20120810_113258_394535_11E6ACC7) Subject: Re: [PATCH wireless?] bcma: keep info about parallel flash presentence From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= To: Arend van Spriel Cc: linux-wireless@vger.kernel.org, "John W. Linville" Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: 2012/8/10 Rafał Miłecki : > 2012/8/10 Arend van Spriel : >> On 08/09/2012 10:38 PM, Rafał Miłecki wrote: >>> This allows drivers to access flash conditionally and stop crashing some >>> devices. >>> >>> Signed-off-by: Rafał Miłecki >>> Acked-by: Hauke Mehrtens >>> --- >>> John: I suggest taking it for wirelesss, AKA fix >> >> Maybe you could mentioned devices and/or drivers crashes without this patch? > > Yes, sure! The problematic one for me is arch/mips/bcm47xx/nvram.c. > Right now it assumes every BCMA board has pflash. I'll submit fix for > mips tree when this patch hits it. Ah, and device. My Netgear WNDR4500 has serial flash and NAND flash. It doesn't have parallel one, so this code crashes my device. -- Rafał