Return-path: Received: from wolverine01.qualcomm.com ([199.106.114.254]:11523 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752223Ab2HTGwz (ORCPT ); Mon, 20 Aug 2012 02:52:55 -0400 Message-ID: <5031DEC2.9020103@qca.qualcomm.com> (sfid-20120820_085259_468774_F75594E8) Date: Mon, 20 Aug 2012 09:52:50 +0300 From: Kalle Valo MIME-Version: 1.0 To: Thomas Pedersen CC: , Subject: Re: [PATCH] ath6kl: rework scheduled scan References: <1345074684-4662-1-git-send-email-c_tpeder@qca.qualcomm.com> In-Reply-To: <1345074684-4662-1-git-send-email-c_tpeder@qca.qualcomm.com> Content-Type: text/plain; charset="ISO-8859-1" Sender: linux-wireless-owner@vger.kernel.org List-ID: On 08/16/2012 02:51 AM, Thomas Pedersen wrote: > This patch reflects changes in the firmware scheduled scan > implementation to behave better in cases with multiple concurrent vifs. > Major changes: > > - scheduled scan filters and state are now programmed per-vif. > - decouple scheduled scan from host sleep. > > To maintain graceful failure with old firmwares, a new firmware > capability bit is introduced: ATH6KL_FW_CAPABILITY_SCHED_SCAN_V2. > ath6kl simply won't advertise scheduled scan to cfg80211 if the > SCHED_SCAN_V2 is not supported. > > Since firmwares from here on out won't support the previous implicit API > for scheduled scan (set WoW filters and host sleep), bump the firmware > API to protect old drivers. Patch looks good but it doesn't apply. Can you rebase and resend, please? > Unfortunately, due to firmware RAM constraints ath6kl still cannot > expect a scan complete event at the end of a scheduled scan results > cycle, so the sched_scan_timer is retained. This is indeed unfortunate. I was so hoping to get rid of the ugly timer. BTW, whenever you can try to avoid using any custom commits when submitting patches upstream, that way it's easier to fix conflicts with 3-way merge: Applying: ath6kl: configure wow filters per-vif fatal: sha1 information is lacking or useless (drivers/net/wireless/ath/ath6kl/cfg80211.c). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Kalle