Message-ID: <5045BFB2.6010701@qca.qualcomm.com> (sfid-20120904_104616_736054_1C0B5909)
Date: Tue, 4 Sep 2012 14:15:38 +0530
From: Vasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com>
MIME-Version: 1.0
To: Kalle Valo <kvalo@qca.qualcomm.com>
CC: <linville@tuxdriver.com>, <johannes@sipsolutions.net>,
	<linux-wireless@vger.kernel.org>
Subject: Re: [RFC 2/2] cfg80211/nl80211: Enable drivers to implement mac address
 based ACL
References: <1346675037-17858-1-git-send-email-vthiagar@qca.qualcomm.com> <1346675037-17858-2-git-send-email-vthiagar@qca.qualcomm.com> <50459FD3.2010305@qca.qualcomm.com>
In-Reply-To: <50459FD3.2010305@qca.qualcomm.com>
Content-Type: text/plain; charset="ISO-8859-1"; format=flowed
Sender: linux-wireless-owner@vger.kernel.org


On Tuesday 04 September 2012 11:59 AM, Kalle Valo wrote:
> On 09/03/2012 03:23 PM, Vasanthakumar Thiagarajan wrote:
>> This patch enables drivers to implement mac address based
>> access control in AP/P2P GO mode. There is a new flag in
>> nl80211_feature_flags (NL80211_FEATURE_MAC_ACL) for drivers
>> to advertise this capability. There are two acl policies, white
>> and black list, under which an acl list can be configured in the
>> driver. Driver has to advertise the maximum number of mac address
>> entries in acl list through max_acl_mac_addrs of wiphy.
>>
>> ACL is enabled/disabled based on attribute NL80211_ATTR_MAC_ACL which
>> is passed in start_ap. A list of stations' mac addresses is set
>> using NL80211_CMD_SET_MAC_ACL.
>
> I would prefer a bit more documentation how this works from user space
> or driver's point of view. I think I can guess how it's supposed to
> work, but it would be good to document it explicitly. For example, it
> wasn't clear how he driver must function when NL80211_ACL_POLICY_ACCEPT
> or DENY is used.

Sure, I'll add more documentation.

>
>> Driver may have to make sure to clear it's acl list when doing start/stop ap.
>
> s/may/must/?

Right, it is must. Thanks!

Vasanth