Return-path: Received: from mx1.redhat.com ([209.132.183.28]:15542 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753771Ab2IJQql (ORCPT ); Mon, 10 Sep 2012 12:46:41 -0400 Message-ID: <1347295769.17507.2.camel@dcbw.foobar.com> (sfid-20120910_184650_275958_9E4E8E33) Subject: Re: [PATCH v3] p54: connect to 11w protected networks From: Dan Williams To: Christian Lamparter Cc: Kalle Valo , linux-wireless@vger.kernel.org, linville@tuxdriver.com Date: Mon, 10 Sep 2012 11:49:29 -0500 In-Reply-To: <201209101759.17751.chunkeey@googlemail.com> References: <1347036664.8913.1.camel@dcbw.foobar.com> <87ehma5agf.fsf@purkki.adurom.net> <201209101759.17751.chunkeey@googlemail.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, 2012-09-10 at 17:59 +0200, Christian Lamparter wrote: > On Monday 10 September 2012 14:28:00 Kalle Valo wrote: > > Dan Williams writes: > > > > > On Tue, 2012-09-04 at 15:19 +0200, Christian Lamparter wrote: > > >> Previously, it was not possible to connect > > >> to networks which requires 11w to be supported > > >> by the stations. > > > > > > If at all possible if we can do this without module parameters, that > > > would be great. Otherwise how is userspace supposed to connect to a > > > W-capable network without twiddling driver-specific module options, > > > something we've tried really hard to not do? Module options really > > > aren't any different than private ioctls or IWPRIV commands... > > > > Sure, and that's how it works with properly supported hardware. But p54 > > is so old that the user will need to buy newer hardware if he really > > needs 11w support out-of-box. IMHO there's no point of making a huge > > effort to add 11w support to older hardware, there are more important > > things to fix in Linux wireless stack than that. > > Dan's concern has been addressed by v4 of this patch > (which depends on johannes' "add mgmt key flags" patch). > p54 should now provide basic support for 11w protected > networks w/o messing with any module parameters. Great, thanks! Dan