Return-path: Received: from wolverine02.qualcomm.com ([199.106.114.251]:26447 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757111Ab2IUJjz (ORCPT ); Fri, 21 Sep 2012 05:39:55 -0400 From: To: CC: , , Raja Mani Subject: [PATCH v2 2/3] ath6kl: Check for valid rate table index Date: Fri, 21 Sep 2012 15:08:54 +0530 Message-ID: <1348220335-29711-2-git-send-email-rmani@qca.qualcomm.com> (sfid-20120921_113958_038082_B43CCFB7) In-Reply-To: <1348220335-29711-1-git-send-email-rmani@qca.qualcomm.com> References: <1348220335-29711-1-git-send-email-rmani@qca.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org List-ID: From: Raja Mani There are 28 items defined in rate table array 'wmi_rate_tbl'. The rate table index (reply->rate_index) in ath6kl_wmi_bitrate_reply_rx() func is not checked for the valid max limit index before accessing rate table array. There may be some incidents to get memory crashes without safe max check. Fix this. Found this on code review. Signed-off-by: Raja Mani --- drivers/net/wireless/ath/ath6kl/wmi.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/net/wireless/ath/ath6kl/wmi.c b/drivers/net/wireless/ath/ath6kl/wmi.c index 64b81fd..f3aeebb 100644 --- a/drivers/net/wireless/ath/ath6kl/wmi.c +++ b/drivers/net/wireless/ath/ath6kl/wmi.c @@ -1174,6 +1174,9 @@ static int ath6kl_wmi_bitrate_reply_rx(struct wmi *wmi, u8 *datap, int len) rate = RATE_AUTO; } else { index = reply->rate_index & 0x7f; + if (WARN_ON_ONCE(index > (RATE_MCS_7_40 + 1))) + return -EINVAL; + sgi = (reply->rate_index & 0x80) ? 1 : 0; rate = wmi_rate_tbl[index][sgi]; } -- 1.7.1