Return-path: Received: from mail-wi0-f178.google.com ([209.85.212.178]:34728 "EHLO mail-wi0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750859Ab2JDJh1 (ORCPT ); Thu, 4 Oct 2012 05:37:27 -0400 Received: by mail-wi0-f178.google.com with SMTP id hr7so490786wib.1 for ; Thu, 04 Oct 2012 02:37:26 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20121003232034.GA19388@localhost.arig> References: <20121003232034.GA19388@localhost.arig> Date: Thu, 4 Oct 2012 11:37:25 +0200 Message-ID: (sfid-20121004_113733_958172_C00E337E) Subject: Re: [PATCH] rt2x00/rt3352: Fix lnagain assignment to use register 66. From: Gertjan van Wingerde To: Daniel Golle Cc: linux-wireless@vger.kernel.org, linville@tuxdriver.com Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Thu, Oct 4, 2012 at 1:20 AM, Daniel Golle wrote: > This should be register 66 instead of 62. > (probably happened by copy&past'ing from the lines below) > > Signed-off-by: Daniel Golle Acked-by: Gertjan van Wingerde John, please apply to the wireless tree for inclusion in 3.7. > > --- > drivers/net/wireless/rt2x00/rt2800lib.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c b/drivers/net/wireless/rt2x00/rt2800lib.c > index 540c94f..01dc889 100644 > --- a/drivers/net/wireless/rt2x00/rt2800lib.c > +++ b/drivers/net/wireless/rt2x00/rt2800lib.c > @@ -2252,9 +2252,9 @@ static void rt2800_config_channel(struct rt2x00_dev *rt2x00dev, > */ > if (rt2x00_rt(rt2x00dev, RT3352)) { > rt2800_bbp_write(rt2x00dev, 27, 0x0); > - rt2800_bbp_write(rt2x00dev, 62, 0x26 + rt2x00dev->lna_gain); > + rt2800_bbp_write(rt2x00dev, 66, 0x26 + rt2x00dev->lna_gain); > rt2800_bbp_write(rt2x00dev, 27, 0x20); > - rt2800_bbp_write(rt2x00dev, 62, 0x26 + rt2x00dev->lna_gain); > + rt2800_bbp_write(rt2x00dev, 66, 0x26 + rt2x00dev->lna_gain); > } else { > rt2800_bbp_write(rt2x00dev, 62, 0x37 - rt2x00dev->lna_gain); > rt2800_bbp_write(rt2x00dev, 63, 0x37 - rt2x00dev->lna_gain); > -- > 1.7.12.2 > -- --- Gertjan