Return-path: Received: from he.sipsolutions.net ([78.46.109.217]:47272 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758164Ab2JXPlj (ORCPT ); Wed, 24 Oct 2012 11:41:39 -0400 Message-ID: <1351093332.10709.5.camel@jlt4.sipsolutions.net> (sfid-20121024_174143_435373_7852C447) Subject: Re: [PATCH 0/4] multi-channel/interface TX power handling From: Johannes Berg To: Ben Greear Cc: linux-wireless@vger.kernel.org Date: Wed, 24 Oct 2012 17:42:12 +0200 In-Reply-To: <50880BD0.6080603@candelatech.com> References: <1351073603-11616-1-git-send-email-johannes@sipsolutions.net> <50880BD0.6080603@candelatech.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, 2012-10-24 at 08:40 -0700, Ben Greear wrote: > On 10/24/2012 03:13 AM, Johannes Berg wrote: > > This was the remaining work I had to do in mac80211, but it > > got a little larger because cfg80211 wasn't doing per-vif > > TX power ... > > > > I disallowed setting TX power per hardware now, we could in > > theory do something like set all interfaces in that case, but > > it seemed like a lot of work for very little gain. If someone > > needs it, we can do it later :-) > > Is there any good way for user-space to know if kernel supports > old or new version? Maybe just try to set per wiphy and if that fails, > try to set per vif? Yeah that'd be the only way, most scripts I've seen always just use the interface anyway though? I'm not totally happy about this, maybe we should iterate all interfaces? Not really sure ... johannes