Return-path: Received: from devils.ext.ti.com ([198.47.26.153]:45209 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753258Ab2JNNfL (ORCPT ); Sun, 14 Oct 2012 09:35:11 -0400 Message-ID: <507ABE44.4080904@ti.com> (sfid-20121014_153517_714653_56F97282) Date: Sun, 14 Oct 2012 15:29:40 +0200 From: Victor Goldenshtein MIME-Version: 1.0 To: Johannes Berg CC: , , , , , , , , , , , Subject: Re: [PATCH v3 7/7] mac80211: add DFS support to monitor interface References: <1344426823-1795-1-git-send-email-victorg@ti.com> <1344426823-1795-8-git-send-email-victorg@ti.com> <1347276361.4272.20.camel@jlt4.sipsolutions.net> <1349808165.4683.15.camel@jlt4.sipsolutions.net> In-Reply-To: <1349808165.4683.15.camel@jlt4.sipsolutions.net> Content-Type: text/plain; charset="UTF-8"; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 10/09/2012 08:42 PM, Johannes Berg wrote: > On Wed, 2012-10-03 at 15:54 +0200, Goldenshtein, Victor wrote: >> On Mon, Sep 10, 2012 at 2:26 PM, Johannes Berg >> wrote: >>> On Wed, 2012-08-08 at 14:53 +0300, Victor Goldenshtein wrote: >>>> AP mode uses monitor interfaces to transmit >>>> management frames which were blocked for "radar >>>> channels" until now. >>>> >>>> Stop dropping packets if we are on 'radar channel' >>>> and the DFS is enabled. >>> >>> Umm, no? Check for dfs_en_tx(). >>> >> >> no need, the AP is started only after the dfs_en_tx(). > > but this is on monitor mode, no? and monitor mode isn't used just for > AP. In fact, AP no longer even uses monitor mode, so you don't need this > at all since you should be working with a new hostapd version that will > get the DFS feature ... and then you're working on a current version > that already no longer uses monitor mode for DFS. Both kernel & hostapd > have to be new enough, so monitor mode won't be used... > right, this patch here from the days AP used monitor mode. I"ll remove it. -- Thanks, Victor.