Return-path: Received: from he.sipsolutions.net ([78.46.109.217]:52091 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760106Ab2JYTnM (ORCPT ); Thu, 25 Oct 2012 15:43:12 -0400 Message-ID: <1351194222.10421.18.camel@jlt4.sipsolutions.net> (sfid-20121025_214315_401116_579F3B4B) Subject: Re: [PATCH] mac80211: Don't inspect Sequence Control field on control frames From: Johannes Berg To: Javier Cardona Cc: linville@tuxdriver.com, Javier Lopez , linux-wireless@vger.kernel.org, devel@lists.open80211s.org Date: Thu, 25 Oct 2012 21:43:42 +0200 In-Reply-To: <1351188618-11155-1-git-send-email-javier@cozybit.com> (sfid-20121025_201029_989398_BC8461E0) References: <1351188618-11155-1-git-send-email-javier@cozybit.com> (sfid-20121025_201029_989398_BC8461E0) Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Thu, 2012-10-25 at 11:10 -0700, Javier Cardona wrote: > Per IEEE Std. 802.11-2012, Sec 8.2.4.4.1, the sequence Control field is > not present in control frames. We noticed this problem when processing > Block Ack Requests. > > Signed-off-by: Javier Cardona > Signed-off-by: Javier Lopez > --- > net/mac80211/rx.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/net/mac80211/rx.c b/net/mac80211/rx.c > index f975f64..bf54336 100644 > --- a/net/mac80211/rx.c > +++ b/net/mac80211/rx.c > @@ -1467,6 +1467,10 @@ ieee80211_rx_h_defragment(struct ieee80211_rx_data *rx) > > hdr = (struct ieee80211_hdr *)rx->skb->data; > fc = hdr->frame_control; > + > + if (ieee80211_is_ctl(fc)) Different question -- why check _is_ctl rather than !_is_data? johannes