Return-path: Received: from na3sys009aog105.obsmtp.com ([74.125.149.75]:38075 "EHLO na3sys009aog105.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750947Ab2JMCDc convert rfc822-to-8bit (ORCPT ); Fri, 12 Oct 2012 22:03:32 -0400 From: Bing Zhao To: Arend van Spriel , "John W. Linville" CC: Linux Wireless List , Kalle Valo , Jouni Malinen , Stanislav Yakovlev , Dan Williams , Larry Finger Date: Fri, 12 Oct 2012 18:55:16 -0700 Subject: RE: [PATCH 1/3] wireless: drivers: make use of WLAN_EID_VENDOR_SPECIFIC Message-ID: <477F20668A386D41ADCC57781B1F7043083B80D8BB@SC-VEXCH1.marvell.com> (sfid-20121013_040336_201704_6D05F0CE) References: <1350037696-23747-1-git-send-email-arend@broadcom.com> <1350037696-23747-2-git-send-email-arend@broadcom.com> In-Reply-To: <1350037696-23747-2-git-send-email-arend@broadcom.com> Content-Type: text/plain; charset=US-ASCII MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: Hi Arend, > The include file linux/ieee80211.h contains three definitions for > the same thing in enum ieee80211_eid due to historic changes: > > /* Information Element IDs */ > enum ieee80211_eid { > : > WLAN_EID_WPA = 221, > WLAN_EID_GENERIC = 221, > WLAN_EID_VENDOR_SPECIFIC = 221, > : > }; > > The standard refers to this as "vendor specific" element so the > other two definitions are better not used. This patch changes the > wireless drivers to use one definition, ie. WLAN_EID_VENDOR_SPECIFIC. > > Cc: Kalle Valo > Cc: Jouni Malinen > Cc: Stanislav Yakovlev > Cc: Dan Williams > Cc: Bing Zhao > Cc: Larry Finger > Signed-off-by: Arend van Spriel For mwifiex part, Acked-by: Bing Zhao Thanks, Bing