Return-path: Received: from nbd.name ([46.4.11.11]:40682 "EHLO nbd.name" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751760Ab2J2OSx (ORCPT ); Mon, 29 Oct 2012 10:18:53 -0400 Message-ID: <508E9048.1060007@openwrt.org> (sfid-20121029_151856_765405_ED202104) Date: Mon, 29 Oct 2012 15:18:48 +0100 From: Felix Fietkau MIME-Version: 1.0 To: Sven Eckelmann CC: linux-wireless@vger.kernel.org, ath9k-devel@lists.ath9k.org, linville@tuxdriver.com, mcgrof@qca.qualcomm.com, Simon Wunderlich Subject: Re: [PATCH] ath9k: Test for TID only in BlockAcks while checking tx status References: <1351513520-23536-1-git-send-email-sven@narfation.org> <508E77DA.8050708@openwrt.org> In-Reply-To: <508E77DA.8050708@openwrt.org> Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 2012-10-29 1:34 PM, Felix Fietkau wrote: > On 2012-10-29 1:25 PM, Sven Eckelmann wrote: >> The ath9k xmit functions for AMPDUs can send frames as non-aggregate in case >> only one frame is currently available. The client will then answer using a >> normal Ack instead of a BlockAck. This acknowledgement has no TID stored and >> therefore the hardware is not able to provide us the corresponding TID. >> >> The TID set by the hardware in the tx status descriptor has to be seen as >> undefined and not as a valid TID value for normal acknowledgements. Doing >> otherwise results in a massive amount of retransmissions and stalls of >> connections. >> >> Users may experience low bandwidth and complete connection stalls in >> environments with transfers using multiple TIDs. >> >> This regression was introduced in b11b160defc48e4daa283f785192ea3a23a51f8e >> ("ath9k: validate the TID in the tx status information"). >> >> Signed-off-by: Sven Eckelmann >> Signed-off-by: Simon Wunderlich > Nice catch, thanks! > Acked-by: Felix Fietkau One more thing: I think this deserves a Cc: stable@vger.kernel.org - Felix