Return-path: Received: from mms2.broadcom.com ([216.31.210.18]:1183 "EHLO mms2.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755708Ab2KVSsm (ORCPT ); Thu, 22 Nov 2012 13:48:42 -0500 Message-ID: <50AE2BB8.106@broadcom.com> (sfid-20121122_194848_463936_391BEBA7) Date: Thu, 22 Nov 2012 14:42:16 +0100 From: "Arend van Spriel" MIME-Version: 1.0 To: "Seth Forshee" cc: linux-wireless@vger.kernel.org, "John W. Linville" , "Franky (Zhenhui) Lin" , "Brett Rudley" , "Roland Vossen" , "Kan Yan" , brcm80211-dev-list@broadcom.com, "Daniel Wagner" Subject: Re: [PATCH v2 12/22] brcmsmac: Add support for writing debug messages to the trace buffer References: <1352988492-21340-1-git-send-email-seth.forshee@canonical.com> <1352988492-21340-13-git-send-email-seth.forshee@canonical.com> <50AA9824.6020308@broadcom.com> In-Reply-To: <50AA9824.6020308@broadcom.com> Content-Type: text/plain; charset=iso-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 11/19/2012 09:35 PM, Arend van Spriel wrote: > On 11/15/2012 03:08 PM, Seth Forshee wrote: >> Add a new brcmsmac_msg trace system to enable writing of debug messages >> to the trace buffer, and add brcms_* macros for storing device debug >> messages in the trace buffer in addition to the printk log buffer. > > Reviewed-by: Pieter-Paul Giesberts > Reviewed-by: Arend van Spriel >> Signed-off-by: Seth Forshee >> --- >> drivers/net/wireless/brcm80211/brcmsmac/Makefile | 3 +- >> .../brcm80211/brcmsmac/brcms_trace_events.h | 68 >> +++++++++++++++++++- >> drivers/net/wireless/brcm80211/brcmsmac/debug.c | 44 +++++++++++++ >> drivers/net/wireless/brcm80211/brcmsmac/debug.h | 40 ++++++++++++ >> 4 files changed, 151 insertions(+), 4 deletions(-) >> create mode 100644 drivers/net/wireless/brcm80211/brcmsmac/debug.c >> create mode 100644 drivers/net/wireless/brcm80211/brcmsmac/debug.h Hi Seth, Internally, we already had a debug.[ch] as we added some debugfs functionality. I am merging your changes into it, but that means your code will be put under the same permissive license as the other source code, ie. Dual BSD/GPL. So I feel obliged to ask: Are you ok with me doing that and do you want me to add your name in the copyright notice? Gr. AvS