Date: Mon, 12 Nov 2012 15:07:01 -0800
From: Greg KH <greg@kroah.com>
To: Maxim Mikityanskiy <maxtram95@gmail.com>,
	linux-wireless@vger.kernel.org
Cc: Larry Finger <Larry.Finger@lwfinger.net>
Subject: Re: [PATCH 00/17] RTL8187SE driver cleanups
Message-ID: <20121112230701.GA4040@kroah.com> (sfid-20121113_000641_525304_F1AC5631)
References: <1352757511-26957-1-git-send-email-maxtram95@gmail.com>
 <50A17A2B.6060301@lwfinger.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
In-Reply-To: <50A17A2B.6060301@lwfinger.net>
Sender: linux-wireless-owner@vger.kernel.org

On Mon, Nov 12, 2012 at 04:37:31PM -0600, Larry Finger wrote:
> On 11/12/2012 03:58 PM, Maxim Mikityanskiy wrote:
> >There are some bug fixes, cleanups and dead code removal for
> >drivers/staging/rtl8187se
> 
> There is a serious problems with your patches. The text in
> Documentation/SubmittingPatches says:
> 
> "All changes to the Linux kernel occur in the form of patches, as
> generated by diff(1).  When creating your patch, make sure to create it
> in "unified diff" format, as supplied by the '-u' argument to diff(1).
> Also, please use the '-p' argument which shows which C function each
> change is in - that makes the resultant diff a lot easier to read.
> Patches should be based in the root kernel source directory,
> not in any lower subdirectory."
> 
> You satisfied the requirements for -u and -p, but you based then on
> the wrong directory. I can use sed to rewrite this version for
> testing, but please use the correct base in future versions.

Yeah, as-is, I can't take these, sorry.  At the least, fix up the
Subject: and the diff level and please resend.

thanks,

greg k-h