Return-path: Received: from mail.ultra-3eti.com ([173.13.207.162]:45517 "EHLO mail.ultra-3eti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751632Ab2KFVqT convert rfc822-to-8bit (ORCPT ); Tue, 6 Nov 2012 16:46:19 -0500 Received: from webmail.3eti.com (rockmx01.rock.corp [192.168.200.4]) by mail.ultra-3eti.com with ESMTP id ADmsR1gVc6GiOTMw (version=TLSv1 cipher=AES128-SHA bits=128 verify=NO) for ; Tue, 06 Nov 2012 16:46:06 -0500 (EST) From: Chaoxing Lin To: "linux-wireless@vger.kernel.org" Subject: RE: minor bug on these three macros for mesh Date: Tue, 6 Nov 2012 21:46:06 +0000 Message-ID: (sfid-20121106_224630_322372_5927AE31) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: Should be two not three. disc_timeout_jiff() root_path_confirmation_jiffies() -----Original Message----- From: Chaoxing Lin Sent: Tuesday, November 06, 2012 4:44 PM To: linux-wireless@vger.kernel.org Subject: minor bug on these three macros for mesh Net/mac80211/mesh_hwmp.c #define max_preq_retries(s) (s->u.mesh.mshcfg.dot11MeshHWMPmaxPREQretries) #define disc_timeout_jiff(s) \ msecs_to_jiffies(sdata->u.mesh.mshcfg.min_discovery_timeout) #define root_path_confirmation_jiffies(s) \ msecs_to_jiffies(sdata->u.mesh.mshcfg.dot11MeshHWMPconfirmationInterval) The "sdata" in these 3 macros should be "s". For now, code just happens to work since caller always passes in "sdata"