Return-path: Received: from mail-vb0-f46.google.com ([209.85.212.46]:35482 "EHLO mail-vb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753759Ab2K1KGG (ORCPT ); Wed, 28 Nov 2012 05:06:06 -0500 Received: by mail-vb0-f46.google.com with SMTP id ff1so7852051vbb.19 for ; Wed, 28 Nov 2012 02:06:06 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1354094932-15703-1-git-send-email-helmut.schaa@googlemail.com> References: <1354031236-8191-1-git-send-email-helmut.schaa@googlemail.com> <1354094932-15703-1-git-send-email-helmut.schaa@googlemail.com> Date: Wed, 28 Nov 2012 11:06:06 +0100 Message-ID: (sfid-20121128_110616_166317_B63B7F9B) Subject: Re: [PATCHv2] rt2x00: Use addr_mask to disallow invalid MAC addresses in mutli-bssid mode From: Gertjan van Wingerde To: Helmut Schaa Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org, sgruszka@redhat.com, IvDoorn@gmail.com Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, Nov 28, 2012 at 10:28 AM, Helmut Schaa wrote: > Reported-by: Petr Stetiar > Signed-off-by: Helmut Schaa Acked-by: Gertjan van Wingerde > --- > drivers/net/wireless/rt2x00/rt2x00dev.c | 7 +++++++ > 1 files changed, 7 insertions(+), 0 deletions(-) > > diff --git a/drivers/net/wireless/rt2x00/rt2x00dev.c b/drivers/net/wireless/rt2x00/rt2x00dev.c > index 69097d1..f9d9754 100644 > --- a/drivers/net/wireless/rt2x00/rt2x00dev.c > +++ b/drivers/net/wireless/rt2x00/rt2x00dev.c > @@ -1182,6 +1182,13 @@ int rt2x00lib_probe_dev(struct rt2x00_dev *rt2x00dev) > rt2x00dev->hw->vif_data_size = sizeof(struct rt2x00_intf); > > /* > + * rt2x00 devices can only use the last n bits of the MAC address > + * for virtual interfaces. > + */ > + rt2x00dev->hw->wiphy->addr_mask[ETH_ALEN - 1] = > + (rt2x00dev->ops->max_ap_intf - 1); > + > + /* > * Determine which operating modes are supported, all modes > * which require beaconing, depend on the availability of > * beacon entries. > -- > 1.7.7 > -- --- Gertjan