Return-path: Received: from mms3.broadcom.com ([216.31.210.19]:3754 "EHLO mms3.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754452Ab2KSUda (ORCPT ); Mon, 19 Nov 2012 15:33:30 -0500 Message-ID: <50AA9789.9070807@broadcom.com> (sfid-20121119_213333_267980_B23725C1) Date: Mon, 19 Nov 2012 21:33:13 +0100 From: "Arend van Spriel" MIME-Version: 1.0 To: "Seth Forshee" cc: linux-wireless@vger.kernel.org, "John W. Linville" , "Franky (Zhenhui) Lin" , "Brett Rudley" , "Roland Vossen" , "Kan Yan" , brcm80211-dev-list@broadcom.com, "Daniel Wagner" Subject: Re: [PATCH v2 09/22] brcm80211: Allow trace support to be enabled separately from debug References: <1352988492-21340-1-git-send-email-seth.forshee@canonical.com> <1352988492-21340-10-git-send-email-seth.forshee@canonical.com> In-Reply-To: <1352988492-21340-10-git-send-email-seth.forshee@canonical.com> Content-Type: text/plain; charset=iso-8859-1; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 11/15/2012 03:07 PM, Seth Forshee wrote: > Since the runtime overhead of trace support is small when tracing is > disabled, users may be interested in turning on trace support while > leaving other debug features off. Add a new config option named > CONFIG_BRCM_TRACING for this purpose. Reviewed-by: Pieter-Paul Giesberts Reviewed-by: Arend van Spriel > Signed-off-by: Seth Forshee > --- > drivers/net/wireless/brcm80211/Kconfig | 11 +++++++++++ > .../brcm80211/brcmsmac/brcms_trace_events.h | 6 +++--- > 2 files changed, 14 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/wireless/brcm80211/Kconfig b/drivers/net/wireless/brcm80211/Kconfig > index c9d811e..3735c27 100644 > --- a/drivers/net/wireless/brcm80211/Kconfig > +++ b/drivers/net/wireless/brcm80211/Kconfig > @@ -63,6 +63,17 @@ config BRCMISCAN > new E-Scan method which uses less memory in firmware and gives no > limitation on the number of scan results. > > +config BRCM_TRACING > + bool "Broadcom device tracing" > + depends on BRCMSMAC || BRCMFMAC > + ---help--- > + If you say Y here, the Broadcom wireless drivers will register > + with ftrace to dump event information into the trace ringbuffer. > + Tracing can be enabled at runtime to aid in debugging wireless > + issues. This option adds a small amount of overhead when tracing > + is disabled. If unsure, say Y to allow developers to better help > + you when wireless problems occur. > + I regard this as a debugging feature. Did you consider making it depend on BRCMDBG instead? Or do you think that BRCMDBG code would affect run-time behavior during tracing. > config BRCMDBG > bool "Broadcom driver debug functions" > depends on BRCMSMAC || BRCMFMAC