Return-path: Received: from mail-we0-f174.google.com ([74.125.82.174]:55277 "EHLO mail-we0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753939Ab2K1TM1 (ORCPT ); Wed, 28 Nov 2012 14:12:27 -0500 Received: by mail-we0-f174.google.com with SMTP id d7so4636651wer.19 for ; Wed, 28 Nov 2012 11:12:26 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1354127104.25524.33.camel@cumari.coelho.fi> References: <1354095769-8724-1-git-send-email-arik@wizery.com> <1354095769-8724-2-git-send-email-arik@wizery.com> <1354113278.25524.28.camel@cumari.coelho.fi> <1354127104.25524.33.camel@cumari.coelho.fi> From: Arik Nemtsov Date: Wed, 28 Nov 2012 21:12:10 +0200 Message-ID: (sfid-20121128_201230_940282_F0C1CA42) Subject: Re: [PATCH 01/20] wl12xx/wl18xx: update default fw logger's settings To: Luciano Coelho Cc: linux-wireless@vger.kernel.org, Ido Reis Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, Nov 28, 2012 at 8:25 PM, Luciano Coelho wrote: > On Wed, 2012-11-28 at 19:46 +0200, Arik Nemtsov wrote: >> On Wed, Nov 28, 2012 at 4:34 PM, Luciano Coelho wrote: >> > On Wed, 2012-11-28 at 11:42 +0200, Arik Nemtsov wrote: >> >> From: Ido Reis >> >> >> >> update the fw logger mode to continuous, and output to dbgpins (uart). >> >> >> >> Signed-off-by: Ido Reis >> >> Signed-off-by: Arik Nemtsov >> >> --- >> > >> > I think for upstream it's best to keep it as it was? Most people won't >> > have the debug pins and won't want to get them continuously. Sending to >> > the host and only on demand seems more reasonable to me. >> >> I think the default settings should be the ones the dev people are >> using. For production a customer can (and will) change this via a >> wlconf file. > > I disagree. What goes upstream is not for the developers, but for the > users. Developers can more easily change the wlconf file (they know > about it), end-users can just send us what we ask, without having to > mangle with wlconf. I think the users won't know what to do with this anyway without some guidance from TI during debugging, so this argument is pretty moot IMHO. I guess we also differ in our point of view about this stuff. When I'm constantly working with an evolving driver, it helps to have the default tuned to my needs. > > >> I also know firsthand that the SDIO logger is pretty bad (misses >> logs). The only way to get decent logging is via the dbg pins. > > The dbg pins also miss logs sometimes, when they come too fast. For > "real life" (ie. mainline) we should assume that most users won't have a > board with dbg pins exposed. > > We can keep this patch in our internal tree. I'm for keeping as little stuff as possible in the internal tree.