MIME-Version: 1.0
In-Reply-To: <50A17A2B.6060301@lwfinger.net>
References: <1352757511-26957-1-git-send-email-maxtram95@gmail.com> <50A17A2B.6060301@lwfinger.net>
From: Maxim Mikityanskiy <maxtram95@gmail.com>
Date: Tue, 13 Nov 2012 19:18:40 +0200
Message-ID: <CAKErNvpCD+HXy10PRJ6CEfZpw6Z8n6yBPwjdYjDv4QW1zUX_xg@mail.gmail.com> (sfid-20121113_181910_062217_7C30D253)
Subject: Re: [PATCH 00/17] RTL8187SE driver cleanups
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Greg Kroah-Hartman <greg@kroah.com>,
	linux-wireless <linux-wireless@vger.kernel.org>
Content-Type: text/plain; charset=ISO-8859-1
Sender: linux-wireless-owner@vger.kernel.org

2012/11/13 Larry Finger <Larry.Finger@lwfinger.net>:
> On 11/12/2012 03:58 PM, Maxim Mikityanskiy wrote:
>>
>> There are some bug fixes, cleanups and dead code removal for
>> drivers/staging/rtl8187se
>
>
> There is a serious problems with your patches. The text in
> Documentation/SubmittingPatches says:
>
> "All changes to the Linux kernel occur in the form of patches, as
> generated by diff(1).  When creating your patch, make sure to create it
> in "unified diff" format, as supplied by the '-u' argument to diff(1).
> Also, please use the '-p' argument which shows which C function each
> change is in - that makes the resultant diff a lot easier to read.
> Patches should be based in the root kernel source directory,
> not in any lower subdirectory."
>
> You satisfied the requirements for -u and -p, but you based then on the
> wrong directory. I can use sed to rewrite this version for testing, but
> please use the correct base in future versions.
>
> Larry
>
>

I'm sorry, I'll remake patches with correct base and resend them.
Really, you could use "cd drivers/staging/rtl8187se" instead of sed,
it might be easier for you.