Return-path: Received: from arroyo.ext.ti.com ([192.94.94.40]:50448 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754778Ab2KMQFY (ORCPT ); Tue, 13 Nov 2012 11:05:24 -0500 Message-ID: <50A26163.10300@ti.com> (sfid-20121113_170533_588228_D22B396C) Date: Tue, 13 Nov 2012 17:04:03 +0200 From: Victor Goldenshtein MIME-Version: 1.0 To: Johannes Berg CC: , , , , , , , , , , Subject: Re: [PATCH v4 1/6] nl80211/cfg80211: add radar detection command/event References: <1350226137-13704-1-git-send-email-victorg@ti.com> <1350226137-13704-2-git-send-email-victorg@ti.com> <1350414099.10177.13.camel@jlt4.sipsolutions.net> <50842569.5000602@ti.com> <1350910543.10166.3.camel@jlt4.sipsolutions.net> <50922A9D.2060409@ti.com> <1352128887.9466.17.camel@jlt4.sipsolutions.net> In-Reply-To: <1352128887.9466.17.camel@jlt4.sipsolutions.net> Content-Type: text/plain; charset="UTF-8"; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 05/11/2012 17:21, Johannes Berg wrote: > On Thu, 2012-11-01 at 09:54 +0200, Victor Goldenshtein wrote: >> On 22/10/2012 14:55, Johannes Berg wrote: >>>> 2. In __nl80211_set_channel() - to cover the case when the CAC was >>>> initiated on a "preset_chan" (during AP init phase) and the IF was >>>> removed before the AP was even started (local->oper_channel wasn't set yet). >>> >>> Hmm, I'm not sure I get it. How is "local->oper_channel" (a mac80211 >>> variable) related to this cfg80211 code? >> >> It's not, just saying that its not set at this point. >> >>> start_ap() isn't expected to be able to succeed until CAC passed >>> successfully, but OTOH the channel isn't configured until then? >> >> right, the initial CAC performed before start_ap(), only by setting the >> channel with __nl80211_set_channel() + radar detection command. > > Hmm. Maybe then the channel should be passed to the radar detection > command instead? That way, it can be passed through, you can allocate a > channel context, etc. Much easier? We already pass the frequency in the radar detection command, the set channel operation comes during hostapd init flow regardless DFS implementation. -- Thanks, Victor.