Message-ID: <50A17A2B.6060301@lwfinger.net> (sfid-20121112_233738_644268_73F23A1F)
Date: Mon, 12 Nov 2012 16:37:31 -0600
From: Larry Finger <Larry.Finger@lwfinger.net>
MIME-Version: 1.0
To: Maxim Mikityanskiy <maxtram95@gmail.com>
CC: greg@kroah.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 00/17] RTL8187SE driver cleanups
References: <1352757511-26957-1-git-send-email-maxtram95@gmail.com>
In-Reply-To: <1352757511-26957-1-git-send-email-maxtram95@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Sender: linux-wireless-owner@vger.kernel.org

On 11/12/2012 03:58 PM, Maxim Mikityanskiy wrote:
> There are some bug fixes, cleanups and dead code removal for
> drivers/staging/rtl8187se

There is a serious problems with your patches. The text in 
Documentation/SubmittingPatches says:

"All changes to the Linux kernel occur in the form of patches, as
generated by diff(1).  When creating your patch, make sure to create it
in "unified diff" format, as supplied by the '-u' argument to diff(1).
Also, please use the '-p' argument which shows which C function each
change is in - that makes the resultant diff a lot easier to read.
Patches should be based in the root kernel source directory,
not in any lower subdirectory."

You satisfied the requirements for -u and -p, but you based then on the wrong 
directory. I can use sed to rewrite this version for testing, but please use the 
correct base in future versions.

Larry