Return-path: Received: from mms2.broadcom.com ([216.31.210.18]:3572 "EHLO mms2.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754321Ab2KSSfQ (ORCPT ); Mon, 19 Nov 2012 13:35:16 -0500 Message-ID: <50AA7BB4.3000209@broadcom.com> (sfid-20121119_193618_848467_B982C5F9) Date: Mon, 19 Nov 2012 19:34:28 +0100 From: "Arend van Spriel" MIME-Version: 1.0 To: "Seth Forshee" cc: linux-wireless@vger.kernel.org, "John W. Linville" , "Franky (Zhenhui) Lin" , "Brett Rudley" , "Roland Vossen" , "Kan Yan" , brcm80211-dev-list@broadcom.com, "Daniel Wagner" Subject: Re: [PATCH v2 02/22] brcmsmac: Don't weight AMPDU packets in txfifo References: <1352988492-21340-1-git-send-email-seth.forshee@canonical.com> <1352988492-21340-3-git-send-email-seth.forshee@canonical.com> In-Reply-To: <1352988492-21340-3-git-send-email-seth.forshee@canonical.com> Content-Type: text/plain; charset=iso-8859-1; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 11/15/2012 03:07 PM, Seth Forshee wrote: > According to the comments this "reduces rate lag," but in reality the > only way this value is used is for determining whether or not any frames > remain to be transmitted. Therefore there's no reason for AMPDU packets > to receive any weighting. Reviewed-by: Pieter-Paul Giesberts Reviewed-by: Arend van Spriel > Signed-off-by: Seth Forshee > --- > drivers/net/wireless/brcm80211/brcmsmac/ampdu.c | 12 +++--------- > drivers/net/wireless/brcm80211/brcmsmac/main.c | 19 +++++++++---------- > drivers/net/wireless/brcm80211/brcmsmac/main.h | 6 ++---- > 3 files changed, 14 insertions(+), 23 deletions(-)