Return-path: Received: from mms2.broadcom.com ([216.31.210.18]:4791 "EHLO mms2.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752003Ab2KNTlY (ORCPT ); Wed, 14 Nov 2012 14:41:24 -0500 Message-ID: <50A3F3CB.4040402@broadcom.com> (sfid-20121114_204137_091366_2DFC67AC) Date: Wed, 14 Nov 2012 20:40:59 +0100 From: "Arend van Spriel" MIME-Version: 1.0 To: "Seth Forshee" cc: linux-wireless@vger.kernel.org, "John W. Linville" , "Franky (Zhenhui) Lin" , "Brett Rudley" , "Roland Vossen" , "Kan Yan" , brcm80211-dev-list@broadcom.com Subject: Re: [PATCH 00/18] brcmsmac: Tx rework and expanded debug/trace support References: <1351261413-20821-1-git-send-email-seth.forshee@canonical.com> <50955ADB.9020703@broadcom.com> <20121104202549.GB24905@ubuntu-mba51> <20121114160559.GA18738@thinkpad-t410> In-Reply-To: <20121114160559.GA18738@thinkpad-t410> Content-Type: text/plain; charset=iso-8859-1; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 11/14/2012 05:05 PM, Seth Forshee wrote: > Hi Arend, > > I've got v2 patches prepped with your request changes, which I'll send > as soon as I'm finished testing. I did have a question about one of your > requests though. > > On Sun, Nov 04, 2012 at 09:25:49PM +0100, Seth Forshee wrote: >> On Sat, Nov 03, 2012 at 06:56:43PM +0100, Arend van Spriel wrote: >>>> brcmsmac: Add module parameter for setting the debug level >>> >>> I would prefer doing this through debugfs. > > I mentioned this to you at the wireless summit. If this is moved to > debugfs it will not allow for setting the debug level at module load > time. If we leave it a module parameter it can still be set at runtime > via /sys/module/parameters/brcmsmac/debug, assuming BRCMDBG is enabled. > I currently don't have this change in my v2 patches, but if you still > want it changed to debugfs let me know and I'll take care of it. > > Thanks, > Seth Indeed we discussed it. I do not have a strong preference and having it set during module init has its perks. So you can leave it as it is. I am looking forward to your v2 patches ;-) Gr. AvS