Return-path: Received: from mail-oa0-f46.google.com ([209.85.219.46]:65269 "EHLO mail-oa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752616Ab2KTMEg (ORCPT ); Tue, 20 Nov 2012 07:04:36 -0500 Received: by mail-oa0-f46.google.com with SMTP id h16so5805414oag.19 for ; Tue, 20 Nov 2012 04:04:35 -0800 (PST) MIME-Version: 1.0 In-Reply-To: References: <1353410411-18833-1-git-send-email-eliad@wizery.com> <1353410411-18833-6-git-send-email-eliad@wizery.com> Date: Tue, 20 Nov 2012 14:04:35 +0200 Message-ID: (sfid-20121120_130439_057703_560C5862) Subject: Re: [PATCH v2 05/11] wlcore: add chanctx implementation From: Eliad Peller To: Arik Nemtsov Cc: Luciano Coelho , "linux-wireless@vger.kernel.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, Nov 20, 2012 at 1:45 PM, Arik Nemtsov wrote: > On Tue, Nov 20, 2012 at 1:20 PM, Eliad Peller wrote: >> Add some basic chanctx implementation - debug prints, >> and save the vif's channel/band/type. >> >> After that, we no longer need to handle channel change >> notifications on op_config. >> >> Signed-off-by: Arik Nemtsov >> Signed-off-by: Eliad Peller >> --- >> + /* update default rates according to the band */ >> + wl1271_set_band_rate(wl, wlvif); > > set_band_rate should be fixed to also set wl->basic_rate. but this can > be a separate patch.. > previously we had some manual code to set the basic_rate, which you removed. as i mentioned before, there is a huge mess in the rates handling. for sta - we set wlvif->basic_rate anyway on CHANGED_BSSID for ap - we don't use it at all, but use wl1271_tx_min_rate_get(wl, wlvif->basic_rate_set) so it's not really an issue. i think we should handle all this in a separate patch. Eliad.