Return-path: Received: from nbd.name ([46.4.11.11]:49536 "EHLO nbd.name" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751671Ab2L0IcA (ORCPT ); Thu, 27 Dec 2012 03:32:00 -0500 Message-ID: <50DC0743.8050608@openwrt.org> (sfid-20121227_093204_637529_4DD67072) Date: Thu, 27 Dec 2012 09:30:59 +0100 From: Felix Fietkau MIME-Version: 1.0 To: Johannes Berg CC: Stephen Hemminger , John Linville , linux-wireless@vger.kernel.org Subject: Re: Fw: [Bug 51901] New: mac80211/cfg.c:1995: possible bad call to memcpy ? References: <20121222135545.1f134c5a@samsung-9> (sfid-20121222_225554_897530_D9193457) <1356594315.15149.1.camel@jlt4.sipsolutions.net> In-Reply-To: <1356594315.15149.1.camel@jlt4.sipsolutions.net> Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 2012-12-27 8:45 AM, Johannes Berg wrote: > On Sat, 2012-12-22 at 13:55 -0800, Stephen Hemminger wrote: > >> static int ieee80211_set_mcast_rate(struct wiphy *wiphy, struct net_device >> *dev, >> int rate[IEEE80211_NUM_BANDS]) >> { >> struct ieee80211_sub_if_data *sdata = IEEE80211_DEV_TO_SUB_IF(dev); >> >> memcpy(sdata->vif.bss_conf.mcast_rate, rate, sizeof(rate)); > > Seems fine to me. If anyone's bothered by the warning, patch welcome, > but the code is ok since it's an array. I think the warning is correct and the code needs to be fixed. Since rate is a function parameter, sizeof(rate) == sizeof(int). I didn't know about this weird aspect of the C standard either, but I verified it with a simple user space test program. ;) - Felix