Return-path: Received: from swampdragon.chaosbits.net ([90.184.90.115]:50391 "EHLO swampdragon.chaosbits.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751537Ab2LZUvO (ORCPT ); Wed, 26 Dec 2012 15:51:14 -0500 Date: Wed, 26 Dec 2012 21:51:12 +0100 (CET) From: Jesper Juhl To: linux-kernel@vger.kernel.org cc: wlanfae , netdev@vger.kernel.org, linux-wireless@vger.kernel.org, "John W. Linville" , Chaoming Li , Larry Finger Subject: [PATCH] rtlwifi: Don't leak on error in _rtl_usb_receive() Message-ID: (sfid-20121226_215137_877292_10FFE447) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-wireless-owner@vger.kernel.org List-ID: We fail to release 'urb' if '_rtl_prep_rx_urb()' fails in _rtl_usb_receive(). This patch should take care of the leak. Signed-off-by: Jesper Juhl --- drivers/net/wireless/rtlwifi/usb.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) note: compile tested only. diff --git a/drivers/net/wireless/rtlwifi/usb.c b/drivers/net/wireless/rtlwifi/usb.c index 29f0969..75c29e6 100644 --- a/drivers/net/wireless/rtlwifi/usb.c +++ b/drivers/net/wireless/rtlwifi/usb.c @@ -640,6 +640,7 @@ static int _rtl_usb_receive(struct ieee80211_hw *hw) RT_TRACE(rtlpriv, COMP_USB, DBG_EMERG, "Failed to prep_rx_urb!!\n"); err = PTR_ERR(skb); + usb_free_urb(urb); goto err_out; } -- 1.7.1 -- Jesper Juhl http://www.chaosbits.net/ Don't top-post http://www.catb.org/jargon/html/T/top-post.html Plain text mails only, please.