Return-path: Received: from mms3.broadcom.com ([216.31.210.19]:4361 "EHLO mms3.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751762Ab2LDTwW (ORCPT ); Tue, 4 Dec 2012 14:52:22 -0500 Message-ID: <50BE5467.6070203@broadcom.com> (sfid-20121204_205225_073782_768E9128) Date: Tue, 4 Dec 2012 20:52:07 +0100 From: "Arend van Spriel" MIME-Version: 1.0 To: "John W. Linville" cc: "Kalle Valo" , "Linux Wireless List" , "Piotr Haber" , "Seth Forshee" Subject: Re: [PATCH V2 v3.7] brcmsmac: handle packet drop on enqueuing correctly References: <1353961396-7061-1-git-send-email-arend@broadcom.com> <50BC63E5.9020101@broadcom.com> <871uf7w6w0.fsf@purkki.adurom.net> <20121203183912.GE26027@tuxdriver.com> <50BCF57E.8020204@broadcom.com> <20121203185914.GH26027@tuxdriver.com> In-Reply-To: <20121203185914.GH26027@tuxdriver.com> Content-Type: text/plain; charset=iso-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 12/03/2012 07:59 PM, John W. Linville wrote: > On Mon, Dec 03, 2012 at 07:54:54PM +0100, Arend van Spriel wrote: >> On 12/03/2012 07:39 PM, John W. Linville wrote: >>> On Mon, Dec 03, 2012 at 04:24:31PM +0200, Kalle Valo wrote: >>>> Hi Arend, >>>> >>>> "Arend van Spriel" writes: >>>> >>>>> What is keeping you from picking up this patch? Anything I should do? >>>>> This V2 removed the no-op changes in ampdu.c that Seth indicated so... >>>> >>>> Most likely it's too late. Dave already told that that John's previous >>>> pull request might not make it to 3.7. >>> >>> Yes, that. Also, given the merge difficulties this creates and the >>> fact that Seth's patch is already queued for 3.8, maybe you should >>> consider sending this for the 3.7 stable series when it opens? >>> >>> John >>> >> >> That was my plan when it would not get in for 3.7.0. I wanted it to go >> to stable anyway as the fix is also needed for 3.6.x stable. Just wanted >> to get it upstream fixed first. >> >> For 3.8 the fix has been reworked on top of Seth patches and is in >> wireless-next (c4dea35e brcmsmac: handle packet drop during transmit >> correctly). Should I refer to that commit when submitting to stable >> (although it is a slightly different patch). > > Yes, I think the stable team will appreciate that. > > Thanks, > > John > Hi John, Not keeping a close eye on LKML, but I noticed 3.7-rc8 is out. Would you reconsider taking this patch for 3.7? Would be nice to be rid of slab corruption in v3.7.0. Gr. AvS