Return-path: Received: from mail-ea0-f181.google.com ([209.85.215.181]:49717 "EHLO mail-ea0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750797Ab3AVWW6 convert rfc822-to-8bit (ORCPT ); Tue, 22 Jan 2013 17:22:58 -0500 Received: by mail-ea0-f181.google.com with SMTP id i13so2178892eaa.12 for ; Tue, 22 Jan 2013 14:22:56 -0800 (PST) References: <20130122164914.GB25134@localhost.localdomain> <2BB3EFC8-0B36-47DA-9FE2-13159E367F85@gmail.com> <50FF00C0.1010402@gmail.com> Mime-Version: 1.0 (1.0) In-Reply-To: <50FF00C0.1010402@gmail.com> Content-Type: text/plain; charset=us-ascii Message-Id: <1F17EC2B-C49B-43CB-B6B1-28D55D638B73@gmail.com> (sfid-20130122_232302_661657_806D0F6E) Cc: Stanislaw Gruszka , "John W. Linville" , "linux-wireless@vger.kernel.org" , "users@rt2x00.serialmonkey.com" From: Gertjan van Wingerde Subject: Re: [PATCH] rt2x00: print chip and firmware version by default Date: Tue, 22 Jan 2013 23:22:52 +0100 To: Xose Vazquez Perez Sender: linux-wireless-owner@vger.kernel.org List-ID: Xose, Sent from my iPad On 22 jan. 2013, at 22:12, Xose Vazquez Perez wrote: > On 01/22/2013 07:58 PM, Gertjan van Wingerde wrote: > >> On 22 jan. 2013, at 17:49, Stanislaw Gruszka wrote: >> >>> Signed-off-by: Stanislaw Gruszka >>> Tested-by: Xose Vazquez Perez >>> --- >>> drivers/net/wireless/rt2x00/rt2x00.h | 2 +- >>> drivers/net/wireless/rt2x00/rt2x00mac.c | 6 +++--- >>> 2 files changed, 4 insertions(+), 4 deletions(-) >>> >>> diff --git a/drivers/net/wireless/rt2x00/rt2x00.h b/drivers/net/wireless/rt2x00/rt2x00.h >>> index 3e37c19..bef449c 100644 >>> --- a/drivers/net/wireless/rt2x00/rt2x00.h >>> +++ b/drivers/net/wireless/rt2x00/rt2x00.h >>> @@ -92,7 +92,7 @@ >>> #define NOTICE(__dev, __msg, __args...) \ >>> DEBUG_PRINTK(__dev, KERN_NOTICE, "Notice", __msg, ##__args) >>> #define INFO(__dev, __msg, __args...) \ >>> - DEBUG_PRINTK(__dev, KERN_INFO, "Info", __msg, ##__args) >>> + DEBUG_PRINTK_MSG(__dev, KERN_INFO, "Info", __msg, ##__args) >>> #define DEBUG(__dev, __msg, __args...) \ >>> DEBUG_PRINTK(__dev, KERN_DEBUG, "Debug", __msg, ##__args) >>> #define EEPROM(__dev, __msg, __args...) \ > >> I think this change is good, but we should also change WARNING and >> NOTICE. Otherwise they won't be displayed if CONFIG_RT2X00_DEBUG is >> disabled, but INFO will, which would be strange. > > I believe this patch is so useful and trivial enough to be included, > as is, in the next 3.8-rc . > > The next steps can be done for 3.9 To be honest, I wouldn't classify this as a bug, so 3.8-rc is out of the question. And doing a respin to add the other log levels can easily be done rather quickly, so there's no need to split it up. --- Gertjan